-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gantt plot nf-test #13
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e04c3e9
Start with tests for the gantt plots
pinin4fjords 65a221b
Fix snapshotting
pinin4fjords e6511ad
Merge branch 'main' into gantt_nftests
pinin4fjords 6634067
restore snap line
pinin4fjords fb6231c
Reset snap
pinin4fjords b8e39af
Don't need log
pinin4fjords 5953d53
Update gantt plot tests
pinin4fjords c83456b
appease eclint
pinin4fjords 76c6748
[skip ci] we'll need to check content
pinin4fjords 0a5d0bd
Fix gantt tests
pinin4fjords 7675c8f
Don't need snapshot
pinin4fjords f3f9735
Fix container config
pinin4fjords File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
nextflow_process { | ||
|
||
name "Test Process PLOT_RUN_GANTT" | ||
script "../main.nf" | ||
process "PLOT_RUN_GANTT" | ||
config "./nextflow.config" | ||
|
||
tag "modules" | ||
tag "modules_local" | ||
tag "plot_run_gantt" | ||
|
||
test("Should run without failures") { | ||
|
||
setup { | ||
run("SEQERA_RUNS_DUMP") { | ||
script "../../seqera_runs_dump/main.nf" | ||
process { | ||
""" | ||
input[0] = ['id': '4Bi5xBK6E2Nbhj', 'workspace': 'community/showcase'] | ||
input[1] = "https://api.tower.nf" | ||
""" | ||
} | ||
} | ||
} | ||
|
||
when { | ||
process { | ||
|
||
""" | ||
input[0] = SEQERA_RUNS_DUMP.out.run_dump | ||
""" | ||
} | ||
} | ||
|
||
then { | ||
assertAll( | ||
{ assert path(process.out.html.get(0).get(1)).getText().contains("GANTT plot for run: 4Bi5xBK6E2Nbhj") }, | ||
{ assert process.success } | ||
) | ||
} | ||
|
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
process { withName: 'SEQERA_RUNS_DUMP' { container = 'public.ecr.aws/seqera-labs/wave/containers:tower-cli-0.9.0--2cb0f2e9d85d026b' } } | ||
process { withName: 'PLOT_RUN_GANTT' { container = 'quay.io/seqeralabs/nf-aggregate:click-8.0.1_pandas-1.1.5_plotly_express-0.4.1_typing-3.10.0.0--342dabfe6548a051' } } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
plot_run_gantt: | ||
- modules/local/plot_run_gantt/** |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this file? Because I added a separate
container.config
? Maybe we need to put this in the process for now and we can move it later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the global container config wasn't pulled into the the tests. I tried using
projectDir
on the config line where you included it, but that didn't do the trick. So I put it in the 'figure out later' box.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I'll have a play locally. Thanks!