-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seqera containers: POC 3 #45
base: main
Are you sure you want to change the base?
Conversation
Tried to set the base registry, not 100% how it works with the |
def mod_container = switch([workflow.containerEngine, workflow.profile]) { | ||
case {it[0] == 'singularity' && it[1].contains('arm')} -> 'click_pandas_plotly_express_typing:3fe674b9fa7b15b8' | ||
case {it[0] == 'singularity'} -> 'click_pandas_plotly_express_typing:a4af841350996386' | ||
case {it[1].contains('arm')} -> 'click_pandas_plotly_express_typing:2e5e17c7ed2d1115' | ||
default -> 'click_pandas_plotly_express_typing:21adb9e2d1b605a5' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These mod_container
definitions should be wrapped into functions, as currently the formal grammar does not support global variable definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also switch
expressions are not currently supported, as I would like to leave room for us to eventually provide our own pattern matching syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's yet another horrible boilerplate code. -1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ewels can this be moved to a config file in the module directory? it would be easier to generate that way. and the pipeline config should include it under a profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting idea - so a module config, but that is simply imported by the pipeline config. I like it! I'll whip up a POC No.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one goal of the new config parser is to remove custom code from the config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I should be able to do it with profiles - the same as POC No.1, but just split up into config files that are bundled with the module 🤔
Dinner now but I'll try later / tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bentsherman - done in #46
Seqera Containers: Proof of concept No. 3
Hardcode container URIs at module level.
Workflow for generating:
nextflow.config
Workflow for usage: (Identical to current usage)
nextflow run -profile docker
orsingularity
,arm
etc. (profile names up for refinement). Same as current.nf-core download
as done currently, no change needed.