Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow insecure connections in any way. #25

Closed
jordeu opened this issue Nov 23, 2021 · 4 comments · Fixed by #29
Closed

Do not allow insecure connections in any way. #25

jordeu opened this issue Nov 23, 2021 · 4 comments · Fixed by #29
Assignees
@jordeu
Milestone
v0.4

Comments

@jordeu
Copy link
Member

jordeu commented Nov 23, 2021 •
edited
Loading

Description

  • Do not allow to use non-SSL connections in any way
  • Do not allow to use self-signed certificates.
  • Review how and which CA certificates are managed. more info
@jordeu jordeu added this to the v0.3 milestone Nov 23, 2021
@pditommaso
Copy link
Collaborator

Hold on, we had a specific request to not have this. Is it really needed?

@jordeu
Copy link
Member Author

jordeu commented Nov 23, 2021

Here I'm talking about this #16 issue that it is already implemented. If this flag is not set connection to a HTTP server is not allowed, only HTTPS.

What was this request about?

@pditommaso
Copy link
Collaborator

To not allow insecure connection with an --insecure flag 😄

@jordeu
Copy link
Member Author

jordeu commented Nov 23, 2021

Ok, I agree. In fact, this was my first idea but I thought that maybe I was to much "security paranoic" 😄 .

Let me rewrite this issue then.

@jordeu jordeu changed the title Rename '--no-secure' to '--insecure' Do not allow insecure connections in any way. Nov 23, 2021
@jordeu jordeu modified the milestones: v0.3, v0.4 Dec 3, 2021
jordeu added a commit that referenced this issue Dec 13, 2021
@jordeu
Do not allow to use non-SSL connections in any way. Resolves #25
890a986
@jordeu jordeu linked a pull request Dec 13, 2021 that will close this issue
Do not allow to use non-SSL connections in any way. Resolves #25 #29
Merged
@jordeu jordeu self-assigned this Dec 13, 2021
jordeu added a commit that referenced this issue Dec 13, 2021
@jordeu
Merge pull request #29 from seqeralabs/task-25-do-not-allow-insecure
b2fb9c1 
Do not allow to use non-SSL connections in any way. Resolves #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordeu jordeu

Labels
None yet
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

Do not allow to use non-SSL connections in any way. Resolves #25 seqeralabs/tower-agent
2 participants
@pditommaso @jordeu