Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow: reconstruct Desired from Delta #238

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Mar 16, 2021

No description provided.

@at-wat at-wat self-assigned this Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #238 (816da64) into master (39e8081) will increase coverage by 0.29%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   60.41%   60.71%   +0.29%     
==========================================
  Files          29       29              
  Lines        1483     1489       +6     
==========================================
+ Hits          896      904       +8     
+ Misses        505      502       -3     
- Partials       82       83       +1     
Impacted Files Coverage Δ
shadow/state.go 65.38% <83.33%> (+1.09%) ⬆️
shadow/shadow.go 78.64% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e8081...816da64. Read the comment docs.

@at-wat at-wat requested a review from a team March 21, 2021 03:13
Copy link
Contributor

@kamatama41 kamatama41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@at-wat at-wat merged commit e04d2b6 into master Mar 22, 2021
@at-wat at-wat deleted the shadow/reconstruct-desired-from-delta branch March 22, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants