Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mqtt.Retryer interface to Device #315

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Add mqtt.Retryer interface to Device #315

merged 2 commits into from
Oct 19, 2021

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Oct 19, 2021 •
edited
Loading

Allow to use Stats()

@at-wat at-wat self-assigned this Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021 •
edited
Loading

Codecov Report

Merging #315 (c9a3678) into master (0dc9c0b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   63.19%   63.19%           
=======================================
  Files          33       33           
  Lines        2228     2228           
=======================================
  Hits         1408     1408           
  Misses        724      724           
  Partials       96       96
Impacted Files Coverage Δ
awsiotdev.go 72.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc9c0b...c9a3678. Read the comment docs.

@at-wat
Copy link
Member Author

at-wat commented Oct 19, 2021

@t-asaka @kamatama41 please take a look

t-asaka
t-asaka approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@t-asaka t-asaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit 8df39ad into master Oct 19, 2021
@at-wat at-wat deleted the add-retryer-to-device branch October 19, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-asaka t-asaka t-asaka approved these changes

@kamatama41 kamatama41 Awaiting requested review from kamatama41

Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@at-wat @t-asaka