Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add type declarations to package #1185

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

ngoclong19
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Description of change

Close #1183.

Build package locally with npm pack, then test with VS Code.
Types were probably hinted.

@WikiRik WikiRik changed the title fix: type declarations is missing from npm package fix(types): add type declarations to package Oct 26, 2022
@WikiRik WikiRik merged commit 5dc5df3 into sequelize:main Oct 26, 2022
@WikiRik
Copy link
Member

WikiRik commented Oct 26, 2022

Thanks!

@ngoclong19 ngoclong19 deleted the types branch October 26, 2022 14:40
@github-actions
Copy link

🎉 This PR is included in version 6.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type declarations is not included inside published npm package
2 participants