feat: configuration for seamless cli use in a typescript project #1438
Conversation
- In this commit, i have modified the templates and did other related changes to add support for typescript projects. - The new changes I made, will automatically detect if the project that uses sequelize-cli is on typescirpt or not and will switch logic based on it.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // examples: {'test', values}, {test}, {"test"} | ||
| // codeql-disable-next-line | ||
| const validValues = | ||
| /^\{((('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))(, ?(('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))*\}$/; |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
There was a problem hiding this comment.
it's a false positive, @WikiRik can you please dismiss this alert? I don't have access to do it myself.
| // examples: {'test', values}, {test}, {"test"} | ||
| // codeql-disable-next-line | ||
| const validValues = | ||
| /^\{((('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))(, ?(('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))*\}$/; |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
| // examples: {'test', values}, {test}, {"test"} | ||
| // codeql-disable-next-line | ||
| const validValues = | ||
| /^\{((('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))(, ?(('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))*\}$/; |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
| // examples: {'test', values}, {test}, {"test"} | ||
| // codeql-disable-next-line | ||
| const validValues = | ||
| /^\{((('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))(, ?(('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))*\}$/; |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
| // examples: {'test', values}, {test}, {"test"} | ||
| // codeql-disable-next-line | ||
| const validValues = | ||
| /^\{((('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))(, ?(('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))*\}$/; |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
| // examples: {'test', values}, {test}, {"test"} | ||
| // codeql-disable-next-line | ||
| const validValues = | ||
| /^\{((('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))(, ?(('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))*\}$/; |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
| // examples: {'test', values}, {test}, {"test"} | ||
| // codeql-disable-next-line | ||
| const validValues = | ||
| /^\{((('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))(, ?(('[A-z0-9 ]+')|("[A-z0-9 ]+")|([A-z0-9 ]+)))*\}$/; |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
|
going to re-open it with another branch |
In this commit, I have modified the templates and made other related changes to add support for typescript projects.
The new changes I made, will automatically detect if the project that uses sequelize-cli is on typescript or not and will switch logic based on it.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testpass with this change (including linting)?Description of change
Link to the issue: #1436
The sequelize-cli didn't have the support for typescript projects and in this PR I implemented certain changes that will make it capable of handling the CLI for both typescript and javascript files, additionally, I have improved the templates to be able to generate both
.tsand.jsfiles for migrations, models, and seeds.