Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/postgres hyphenated db names #555

Conversation

alexbakerdev
Copy link

Addresses issues in #545

  • Wrap database name with quotes in create and drop scripts, if dialect is Postgres.
  • Update tests to use hyphens in Postgres create and drop db tests, to prevent regression.

@sushantdhiman
Copy link
Contributor

I have fixed this by using sequelize quoteIdentifier , and even tests are passing (in master)

const databaseName = `my_test-db_${_.random(10000, 99999)}`;

Are you certain you are trying this on v3.0.0 ?

@alexbakerdev
Copy link
Author

Aha, I must admit I did not check to see if it had been fixed since I made a quick hacky solution on Thursday. Did not see why the ticket was closed, my bad.

@alexbakerdev alexbakerdev deleted the bug/postgres-hyphenated-db-names branch September 23, 2017 18:10
codetriage-readme-bot pushed a commit to codetriage-readme-bot/cli that referenced this pull request Jun 5, 2019
…ln_argument_with_new_line

Avoids ending Println parameter with new lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants