propagating ssl=true from --url into dialectOptions #788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to the database using the
--url
option I noticed the ssl options are ignored. The only option being to revert to a config file specifyingdialectOptions
directly there.While it worked just fine it felt too cumbersome to manage when the rest of the app configuration is made via env variables.
Digging a little bit into the code turns out the url parser fully supports the
ssl=true
option yet doesn't propagates it further into theconfig
object to have a Sequelize instance initialised.This small change addresses the issue.
Fixes #154