Feature/ci #972
Merged
Feature/ci #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WikiRik
reviewed
Nov 4, 2021
| }, | ||
| "commitlint": { | ||
| "extends": [ | ||
| "@commitlint/config-angular" |
There was a problem hiding this comment.
Any specific reason why you use this configuration?
There was a problem hiding this comment.
it's a copy from sequelize/sequelize
| } | ||
| }, | ||
| "husky": { | ||
| "hooks": { |
There was a problem hiding this comment.
Maybe add a pre-commit hook that runs the linter?
There was a problem hiding this comment.
And possibly with lint-staged to make it quicker
| @@ -8,6 +8,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| node-version: [10, 12, 14] | |||
There was a problem hiding this comment.
Node 16 is now LTS, maybe include that as well? Not sure what the policy is from the main repo on supported Node versions
|
@WikiRik I'll have a look into your suggestions today or throughout the weekend! |
Merged
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding releasing with semantic-release