Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax errors of generated TypeScript code in ts-helper.js #178

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Fix syntax errors of generated TypeScript code in ts-helper.js #178

merged 1 commit into from
Jul 28, 2017

Conversation

isac322
Copy link
Contributor

@isac322 isac322 commented Jul 28, 2017

#176 is very useful but I think it's generating a syntax error code.

Example:

import sequelize from 'sequelize';

should change to

import * as sequelize from 'sequelize';

Found in microsoft/TypeScript#3337.

@mention-bot
Copy link

@isac322, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gsdnano to be a potential reviewer.

@durango durango merged commit 6ecb3d9 into sequelize:master Jul 28, 2017
@durango
Copy link
Member

durango commented Jul 28, 2017

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants