Skip to content

connect using URI connection string support #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 17, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/interfaces/ISequelizeConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export interface ISequelizeConfig extends Options {
/**
* Name of database
*/
name: string;
database: string;

/**
* Username of database
Expand Down
36 changes: 36 additions & 0 deletions lib/interfaces/ISequelizeDbNameConfig.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import {Options} from 'sequelize';

/**
* This class is dedicated for deprecated "name" property.
* For congruence to Sequelize config, use "database" instead.
*/
export interface ISequelizeDbNameConfig extends Options {

/**
* Name of database
* @deprecated: name is deprecated. Use database instead.
*/
name: string;

/**
* Username of database
*/
username: string;

/**
* Password for database user
*/
password: string;

/**
* Path to models, which should be loaded
*/
modelPaths?: string[];

/**
* Makes it possible to use sequelize for validation only
* if set to true. For this configuration it is always false.
* See ISequelizeValidationOnlyConfig interface
*/
validateOnly?: false;
}
21 changes: 21 additions & 0 deletions lib/interfaces/ISequelizeUriConfig.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import {Options} from 'sequelize';

export interface ISequelizeUriConfig extends Options {

/**
* Uri connection string to database
*/
uri: string;

/**
* Path to models, which should be loaded
*/
modelPaths?: string[];

/**
* Makes it possible to use sequelize for validation only
* if set to true. For this configuration it is always false.
* See ISequelizeValidationOnlyConfig interface
*/
validateOnly?: false;
}
27 changes: 22 additions & 5 deletions lib/models/BaseSequelize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import {Model} from "./Model";
import {DEFAULT_DEFINE_OPTIONS, getModels} from "../services/models";
import {getAssociations, processAssociation} from "../services/association";
import {ISequelizeConfig} from "../interfaces/ISequelizeConfig";
import {ISequelizeUriConfig} from "../interfaces/ISequelizeUriConfig";
import {ISequelizeDbNameConfig} from "../interfaces/ISequelizeDbNameConfig";
import {SequelizeConfig} from "../types/SequelizeConfig";
import {resolveScopes} from "../services/scopes";
import {ISequelizeValidationOnlyConfig} from "../interfaces/ISequelizeValidationOnlyConfig";
import {extend} from "../utils/object";
Expand All @@ -19,6 +22,14 @@ export abstract class BaseSequelize {
thoughMap: { [through: string]: any } = {};
_: { [modelName: string]: (typeof Model) } = {};

static isISequelizeDbNameConfig(obj: any): obj is ISequelizeDbNameConfig {
return obj.hasOwnProperty("name") && obj.hasOwnProperty("username");
}

static isISequelizeUriConfig(obj: any): obj is ISequelizeUriConfig {
return obj.hasOwnProperty("uri");
}

static extend(target: any): void {

extend(target, this);
Expand All @@ -27,7 +38,7 @@ export abstract class BaseSequelize {
/**
* Prepares sequelize config passed to original sequelize constructor
*/
static prepareConfig(config: ISequelizeConfig | ISequelizeValidationOnlyConfig): ISequelizeConfig {
static prepareConfig(config: SequelizeConfig | ISequelizeValidationOnlyConfig): SequelizeConfig {
if (!config.define) {
config.define = {};
}
Expand All @@ -37,13 +48,19 @@ export abstract class BaseSequelize {

return this.getValidationOnlyConfig(config);
}
return {...config as ISequelizeConfig};

if (BaseSequelize.isISequelizeDbNameConfig(config)) {
// @TODO: remove deprecated "name" property
return {...config, database: config.name} as ISequelizeConfig;
}

return {...config as SequelizeConfig};
}

static getValidationOnlyConfig(config: ISequelizeConfig | ISequelizeValidationOnlyConfig): ISequelizeConfig {
static getValidationOnlyConfig(config: SequelizeConfig | ISequelizeValidationOnlyConfig): ISequelizeConfig {
return {
...config,
name: '_name_',
database: '_name_',
username: '_username_',
password: '_password_',
dialect: 'sqlite',
Expand All @@ -64,7 +81,7 @@ export abstract class BaseSequelize {
models.forEach(model => this._[model.name] = model);
}

init(config: ISequelizeConfig): void {
init(config: SequelizeConfig): void {

if (config.modelPaths) this.addModels(config.modelPaths);
}
Expand Down
6 changes: 3 additions & 3 deletions lib/models/Sequelize.d.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
/// <reference types="sequelize" />
import 'reflect-metadata';
import * as SequelizeOrigin from 'sequelize';
import {Model} from "./Model";
import {ISequelizeConfig} from "../interfaces/ISequelizeConfig";
import {SequelizeConfig} from "../types/SequelizeConfig";
import {ISequelizeValidationOnlyConfig} from "../interfaces/ISequelizeValidationOnlyConfig";

export declare class Sequelize extends SequelizeOrigin {

_: {[modelName: string]: (typeof Model)};

constructor(config: ISequelizeConfig | ISequelizeValidationOnlyConfig);
constructor(config: SequelizeConfig | ISequelizeValidationOnlyConfig);
constructor(uri: string);

addModels(models: Array<typeof Model>): void;
addModels(modelPaths: string[]): void;
Expand Down
31 changes: 16 additions & 15 deletions lib/models/v3/Sequelize.ts
Original file line number Diff line number Diff line change
@@ -1,40 +1,41 @@
import 'reflect-metadata';
import * as SequelizeOrigin from 'sequelize';
import {Model} from "../Model";
import {ISequelizeConfig} from "../../interfaces/ISequelizeConfig";
import {SequelizeConfig} from "../../types/SequelizeConfig";
import {getModelName, getAttributes, getOptions} from "../../services/models";
import {PROPERTY_LINK_TO_ORIG} from "../../services/models";
import {BaseSequelize} from "../BaseSequelize";
import {Table} from "../../annotations/Table";
import {ISequelizeAssociation} from "../../interfaces/ISequelizeAssociation";

let preparedConfig;

export class Sequelize extends SequelizeOrigin implements BaseSequelize {

// to fix "$1" called with something that's not an instance of Sequelize.Model
Model: any = Function;

thoughMap: { [through: string]: any } = {};
_: { [modelName: string]: typeof Model } = {};
init: (config: ISequelizeConfig) => void;
init: (config: SequelizeConfig) => void;
addModels: (models: Array<typeof Model> | string[]) => void;
associateModels: (models: Array<typeof Model>) => void;

constructor(config: ISequelizeConfig) {
// a spread operator would be the more reasonable approach here,
// but this is currently not possible due to a bug by ts
// https://github.com/Microsoft/TypeScript/issues/4130
// TODO@robin probably make the constructor private and
// TODO use a static factory function instead
constructor(config: SequelizeConfig | string) {

super(
(preparedConfig = BaseSequelize.prepareConfig(config), preparedConfig.name),
preparedConfig.username,
preparedConfig.password,
preparedConfig
(typeof config === "string") ?
config : // URI string
BaseSequelize.isISequelizeUriConfig(config) ?
config.uri : // URI string from ISequelizeUriConfig
BaseSequelize.prepareConfig(config) // Config object (ISequelizeConfig)
);

this.init(config);
if (BaseSequelize.isISequelizeUriConfig(config)) {
this.options = {...this.options, ...config};
}

if (typeof config !== "string") {
this.init(config);
}
}

getThroughModel(through: string): typeof Model {
Expand Down
33 changes: 17 additions & 16 deletions lib/models/v4/Sequelize.ts
Original file line number Diff line number Diff line change
@@ -1,36 +1,37 @@
import 'reflect-metadata';
import * as OriginSequelize from 'sequelize';
import {Model} from "../Model";
import {ISequelizeConfig} from "../../interfaces/ISequelizeConfig";
import {SequelizeConfig} from "../../types/SequelizeConfig";
import {getModelName, getAttributes, getOptions} from "../../services/models";
import {BaseSequelize} from "../BaseSequelize";
import {Table} from "../../annotations/Table";
import {ISequelizeAssociation} from "../../interfaces/ISequelizeAssociation";

let preparedConfig;

export class Sequelize extends OriginSequelize implements BaseSequelize {

thoughMap: {[through: string]: any} = {};
_: {[modelName: string]: typeof Model} = {};
init: (config: ISequelizeConfig) => void;
addModels: (models: Array<typeof Model>|string[]) => void;
init: (config: SequelizeConfig) => void;
addModels: (models: Array<typeof Model> | string[]) => void;
associateModels: (models: Array<typeof Model>) => void;

constructor(config: ISequelizeConfig) {
// a spread operator would be the more reasonable approach here,
// but this is currently not possible due to a bug by ts
// https://github.com/Microsoft/TypeScript/issues/4130
// TODO@robin probably make the constructor private and
// TODO use a static factory function instead
constructor(config: SequelizeConfig | string) {

super(
(preparedConfig = BaseSequelize.prepareConfig(config), preparedConfig.name),
preparedConfig.username,
preparedConfig.password,
preparedConfig
(typeof config === "string") ?
config : // URI string
BaseSequelize.isISequelizeUriConfig(config) ?
config.uri : // URI string from ISequelizeUriConfig
BaseSequelize.prepareConfig(config) // Config object (ISequelizeConfig)
);

this.init(config);
if (BaseSequelize.isISequelizeUriConfig(config)) {
this.options = {...this.options, ...config};
}

if (typeof config !== "string") {
this.init(config);
}
}

getThroughModel(through: string): typeof Model {
Expand Down
5 changes: 5 additions & 0 deletions lib/types/SequelizeConfig.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import {ISequelizeConfig} from "../interfaces/ISequelizeConfig";
import {ISequelizeUriConfig} from "../interfaces/ISequelizeUriConfig";
import {ISequelizeDbNameConfig} from "../interfaces/ISequelizeDbNameConfig";

export type SequelizeConfig = ISequelizeConfig | ISequelizeUriConfig | ISequelizeDbNameConfig;
36 changes: 18 additions & 18 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@
"main": "index.js",
"types": "index.d.ts",
"dependencies": {
"@types/bluebird": "3.5.4",
"@types/node": "6.0.41",
"@types/reflect-metadata": "0.0.4",
"@types/sequelize": "4.0.68",
"@types/sequelize": "4.0.69",
"es6-shim": "0.35.3"
},
"devDependencies": {
Expand Down
Loading