Throw the original error from authenticate

[seanjh]

When the authenticate method catches errors, it wraps those errors in a new Error() call, rather than just throwing the original error. This gobbles up the original name and message into the new error's message parameter, making it more difficult to make use of the error result than necessary.

What's currently happening:

var seqError = new sequelize.Error('YOLO');
try {
  throw new Error(seqError);
} catch (e) {
  if (e instanceof sequelize.Error) {
    console.log('Hooray, I can tell this is a Sequelize error!');
  } else {
    console.log('Bummer. I cannot easily distinguish this from a generic error.');
  }
}

Bummer. I cannot easily distinguish this from a generic error.

What would be preferred:

var seqError = new sequelize.Error('YOLO');
try {
  throw seqError;
} catch (e) {
  console.log(util.inspect(e));
  if (e instanceof sequelize.Error) {
    console.log('Hooray, I can tell this is a Sequelize error!');
  } else {
    console.log('Bummer. I cannot easily distinguish this from a generic error.');
  }
}

Hooray, I can tell this is a Sequelize error!

[janmeier]

Not even sure we need a catch clause here

[mickhansen]

catching to wrap an error in an error, the original quote was definitely wonky.

[janmeier]

ping @seanjh Can you remove this cath completely, then I'll merge :)

[janmeier]

Yeah, makes sense :)

[janmeier]

Thanks! :)