Bugfix for the problems related to eager loading associations and subsequent saving of DAO instances #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctually check that we have a rawAttribute definition for each value we attempt to validate (seems that it is possible to set stuff into a doa instance even though the model does not know about a given property)
…ld have been "username" (note that this broken test has nothing to do with the changes in this branch :-/)
…QL was correct but the test assumed that the fields were specified in a different order (I think switching from `doa.values` to `dao.dataValues` affected the order of field names in generated SQL)
janmeier
added a commit
that referenced
this pull request
Jun 24, 2013
Bugfix for the problems related to eager loading associations and subsequent saving of DAO instances
janmeier
added a commit
that referenced
this pull request
Jun 24, 2013
|
You sir, are nothing short of awesome! 3 issues closed by merging one PR - thanks :) |
|
:) thanks ... it's nice to have contributions accepted - you guys do a pretty good job running this project. |
|
is this change available in any npm-able version? I did an npm install for 1.7.0-alpha2 (which is the version currently in master) but still seeing the issue. |
|
@kevinludwig you'll have to npm install from git unfortunately. |
|
@kevinludwig If you're not able to install from git due to deployment issues, or you just don't like the sound of it, a decent work around is to just .build your include object before saving, eg saveableObj = Instance.build(includeyObject.values, {isNewRecord:false}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a fix for the problems outlined in #715, some buster tests now included