migration return array failed to execute

[greatghoul]

error details

== 20180828102922-add-sponsor-intro-to-lotteries: migrating =======

ERROR: Error: Migration 20180828102922-add-sponsor-intro-to-lotteries.js (or wrapper) didn't return a promise
    at /Users/greatghoul/Workspace/Miidii/Sweetfoot/node_modules/umzug/lib/migration.js:132:15
    at Generator.next (<anonymous>)
    at step (/Users/greatghoul/Workspace/Miidii/Sweetfoot/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /Users/greatghoul/Workspace/Miidii/Sweetfoot/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
    at process._tickCallback (internal/process/next_tick.js:68:7)

migration file

'use strict';

module.exports = {
  up: (queryInterface, Sequelize) => {
    return [
      queryInterface.addColumn('Lotteries', 'sponsor_intro', {
        type: Sequelize.TEXT,
        allowNull: true,
      }),
      queryInterface.addColumn('Lotteries', 'prefs', {
        type: Sequelize.JSONB,
        allowNull: false,
        defaultValue: {},
      }),
      queryInterface.addColumn('Lotteries', 'award_usage', {
        type: Sequelize.TEXT,
        allowNull: true,
      }),
      queryInterface.addColumn('Lotteries', 'award_price', {
        type: Sequelize.STRING,
        allowNull: true,
      }),
    ];
  },

  down: (queryInterface, Sequelize) => {
    return [
      queryInterface.removeColumn('Lotteries', 'sponsor_intro'),
      queryInterface.removeColumn('Lotteries', 'prefs'),
      queryInterface.removeColumn('Lotteries', 'award_usage'),
      queryInterface.removeColumn('Lotteries', 'award_price'),
    ];
  }
};

[Lax]

I guess it should be using Promise instead of Array.

return queryInterface.addColumn(...)
             .then(() => {
               return queryInterface.addColumn(...)
             })
             .then(...)

[greatghoul]

promise style always works, but array style is now broken.

[akenger]

Ran into this today as well...

[spathon]

Was an easy fix for me to just change return [ to return Promise.all([ and ending ])
Should probably have been a Major semver update as it's a breaking change?

[greatghoul]

I locked umzug to 2.1.0.

{
  "dependencies": {
    ...
    "umzug": "2.1.0",
    ...
  }
}

[samathan]

Hi,

Below is my migration script,
'use strict';

module.exports = {
up: (queryInterface, Sequelize) => {
return
queryInterface.addColumn( 'tablename', 'columnname1', Sequelize.BLOB)
.then(() => {
return queryInterface.addColumn( 'tablename', 'columnname2', Sequelize.STRING);
})
},

down: (queryInterface, Sequelize) => {
return
queryInterface.removeColumn( 'tablename1', 'columnname1' )
.then(() => {
return queryInterface.removeColumn( 'tablename1', 'columnname2' );
});
}
}
Below error while executing the above migration ,
== 20181203091310-nameassets-addcolumns: migrating =======

ERROR: Migration 20181203091310-nameassets-addcolumns.js (or wrapper) didn't return a promise

Can some help me with this?
Thank you.

[greatghoul]

'use strict';

module.exports = {
  up: (queryInterface, Sequelize) => {
    return // <---- it returns here, code below this line not executed.
    queryInterface.addColumn('tablename', 'columnname1', Sequelize.BLOB)
      .then(() => {
        return queryInterface.addColumn('tablename', 'columnname2', Sequelize.STRING);
      })
  },

  down: (queryInterface, Sequelize) => {
    return
    queryInterface.removeColumn('tablename1', 'columnname1')
      .then(() => {
        return queryInterface.removeColumn('tablename1', 'columnname2');
      });
  }
}

@samathan you should change it to

'use strict';

module.exports = {
  up: (queryInterface, Sequelize) => {
    return queryInterface.addColumn('tablename', 'columnname1', Sequelize.BLOB)
      .then(() => {
        return queryInterface.addColumn('tablename', 'columnname2', Sequelize.STRING);
      })
  },

  down: (queryInterface, Sequelize) => {
    return queryInterface.removeColumn('tablename1', 'columnname1')
      .then(() => {
        return queryInterface.removeColumn('tablename1', 'columnname2');
      });
  }
}

[Ricardonacif]

Question is: do we wanna keep the array support or are we dropping it?

[greatghoul]

I vote for the array support.

[toddpla]

After reinstalling version sequelize 4.36.1 & sequelize-cli 4.0.0 then running migrations locally I came across this issue. It would be useful to know whether there is a way to revert back to how it was before this change was implemented. Are there any release notes on this?

[thutv18]

Hi @toddpla ,

I've tried re-install the sequelize. It still does not work.
This is error:

This is my migration:

[spathon]

@thutv18 You could easily fix your migration by wrapping it in a Promise.all
Eg return Promise.all([ queryInterface.addColumn ... ])

[thutv18]

Thank @spathon ,
I knew this solution. But, i'm working on the existed database with many files migration. So the effort to update all files is very much.
However, I found other solution for this case. Using "node_modules/.bin/sequelize db:migrate" to run. It works for me

[enbermudas]

This error is happening to me while using the db:seed:undo:all command. The Promise.all([...]) solution is not working either.

Sequelize version: ^5.21.5

Current code:

const baseRecord = {
  description: 'Description...',
  createdAt: new Date(),
  updatedAt: new Date(),
};

const records = ['Fire', 'Water', 'Earth', 'Wind'];

module.exports = {
  up: queryInterface => {
    return queryInterface.bulkInsert(
      'Elements',
      records.map(name => ({ name, ...baseRecord })),
    );
  },

  down: () => queryInterface =>
    Promise.all([queryInterface.bulkDelete('Elements', null, {})]),
};

[sushantdhiman]

@enbermudas down function is returning another function instead of promise. Here is the correct version

down: queryInterface =>
    Promise.all([queryInterface.bulkDelete('Elements', null, {})]),

[renanmachad]

The use of Promise.all ( [ queryInterfaces here] ) , resolves the problem.