Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSC: new feature to add sixth order cross kerr terms #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qci-chou
Copy link
Member

This implementation tries to follow what was done to add cross-kerr terms. If we are interested in adding generic coupling terms, maybe we want to do something more general. e.g. system.add_coupling_term('my_coupling_term', arbitrary_coupling_H0, strength)

@qci-chou qci-chou requested a review from loganbvh July 19, 2021 19:54
@loganbvh
Copy link
Member

If we are interested in adding generic coupling terms, maybe we want to do something more general. e.g. system.add_coupling_term('my_coupling_term', arbitrary_coupling_H0, strength)

I think I would prefer a general implementation rather a different one for each order, or putting this specific method on OCPSystem instead

@qci-chou
Copy link
Member Author

I also agree that a general approach for adding coupling terms is the right thing to do. I can add this to OCPSystem instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants