Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version pin foundry #116

Closed
kayabaNerve opened this issue Sep 5, 2022 · 2 comments
Closed

Version pin foundry #116

kayabaNerve opened this issue Sep 5, 2022 · 2 comments
Labels
CI/CD Continuous integration workflows improvement This could be better

Comments

@kayabaNerve
Copy link
Member

foundry recently updated, and in doing so, broke our CI requiring the following fix: 8d56c43

The fix was beneficial, making this arguably for the better, yet unappreciated as it caused unrelated comments to error for no reason.

#114 similarly errored due to a new version of nightly. While the fixes it mandated were appreciated, it's abruptness wasn't.

Perhaps its pinned with a job to update them every month? Then we'd have an automatic PR prompting us and we can respond to newly caught issues with it.
@kayabaNerve kayabaNerve added the improvement This could be better label Sep 5, 2022
kayabaNerve added a commit that referenced this issue Sep 17, 2022
@kayabaNerve
Pin nightly used for fmt/clippy
c96b595 
As per #116.
@kayabaNerve
Copy link
Member Author

The above pinned fmt/clippy yet didn't create a script for a monthly PR, nor did it pin the wasm toolchain (which is on nightly). I'm also unsure if we can pin foundry, which wasn't handled here.

kayabaNerve added a commit that referenced this issue Sep 18, 2022
@kayabaNerve
Add a workflow file to update the nightly version every month (#118)
a52b2e2 
Part of #116
@kayabaNerve
Copy link
Member Author

Rust is now fully pinned. It appears foundry cannot be pinned at this time, unless we build it from source (dropping the provided action) AND that'll have to be via the git commit as an ID.

@kayabaNerve kayabaNerve changed the title Version pin foundry and nightly Version pin foundry Sep 22, 2022
@TheArchitect108 TheArchitect108 added the CI/CD Continuous integration workflows label Nov 15, 2022
@kayabaNerve kayabaNerve mentioned this issue Nov 19, 2023
Closed
davidjohnbell pushed a commit to econsta/serai that referenced this issue Nov 20, 2023
@kayabaNerve @davidjohnbell
Version pin foundry
3400701 
Fixes serai-dex#116 and serai-dex#441.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD Continuous integration workflows improvement This could be better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kayabaNerve @TheArchitect108