Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename coins folder to networks #357

Closed
kayabaNerve opened this issue Aug 24, 2023 · 1 comment · Fixed by #583
Closed

Rename coins folder to networks #357

kayabaNerve opened this issue Aug 24, 2023 · 1 comment · Fixed by #583
Labels
improvement This could be better

Comments

@kayabaNerve
Copy link
Member

9f143a9 renamed it within the processor, yet the folder in the repo, the audits folder, and potentially some lingering references (orchestration?) still use the terms "coins". This is sub-optimal due to Ethereum being a network with coins (where coins includes tokens) Ether and DAI, yet labelled a coin itself.

I'd simply rename it myself now, yet it'd be better to wait until existing PRs expecting coins/ are resolved.
@kayabaNerve kayabaNerve added the improvement This could be better label Aug 24, 2023
kayabaNerve added a commit that referenced this issue Jul 17, 2024
@kayabaNerve
Rename the coins folder to networks
acb4c08 
Ethereum isn't a coin. It's a network.

Resolves #357.
@kayabaNerve
Copy link
Member Author

networks/ethereum should also be under processor/, as it is tightly coupled and not practically reusable at this time. That's prob fine to kick till #569 though.

@kayabaNerve kayabaNerve mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement This could be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename the coins folder to networks serai-dex/serai
1 participant
@kayabaNerve