#560 take two, now that #560 has been reverted #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayabaNerve
force-pushed
the
tendermint-redo-2
branch
from
f3f7683
to
72419d7
Compare
|
The upons fix is critical for consensus, the round proposal part is an efficiency improvement (as off-hand, I'd assume this lib is slower than the prior lib, even if it's clearer and capable of being audited). |
This was referenced Jul 3, 2024
Identified by @akildemir.
kayabaNerve
force-pushed
the
tendermint-redo-2
branch
from
04e86ff
to
5278d5d
Compare
* fix p2p Reqres protocol * stabilize tributary chain sync * fix pr comments
|
🥳 @akildemir for the credit on this crossing the finish line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
933b17a for the comments on why this was reverted.
There's probably some typo/massive perf issue here needing resolving? Rebroadcasting frequency?