Avoid hashing headers twice in verify_justification (paritytech#973)

serban300 · May 19, 2021 · 66e1508 · 66e1508
1 parent a31844f
commit 66e1508
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/primitives/header-chain/src/justification.rs b/primitives/header-chain/src/justification.rs
@@ -109,12 +109,8 @@ where
 		}
 	}
 
-	let ancestry_hashes = justification
-		.votes_ancestries
-		.iter()
-		.map(|h: &Header| h.hash())
-		.collect();
-	if visited_hashes != ancestry_hashes {
+	// both iterators are `BTree*` iterators, so have the same order => safe to compare
+	if !visited_hashes.iter().eq(ancestry_chain.ancestry.keys()) {
 		return Err(Error::InvalidPrecommitAncestries);
 	}