Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on a windows server with FF14 client #23

Open
MauritsMeijer opened this issue Sep 4, 2012 · 7 comments
Open

Doesn't work on a windows server with FF14 client #23

MauritsMeijer opened this issue Sep 4, 2012 · 7 comments

Comments

@MauritsMeijer
Copy link

The slashes in the script tag become \ in windows and FF doesn't correct it
It seems to work after changing filename in line 255 to
filename.split(path.sep).join('/')

@serby
Copy link
Owner

serby commented Sep 4, 2012

Thanks for letting me know. I think the problem comes from the normalize on line 166. I think that if removed it will fix the problem. Might need to remove any extra slashes too though.

serby pushed a commit that referenced this issue Sep 4, 2012
@serby
Copy link
Owner

serby commented Sep 4, 2012

This should now be fixed in 0.1.2. Can you test it for me please?

@MauritsMeijer
Copy link
Author

It renders a single backslash now, instead of a double one, but FF still can't handle it.

@MauritsMeijer
Copy link
Author

sorry, it works in production, doesn't in development mode.

@serby
Copy link
Owner

serby commented Sep 5, 2012

Could you write a regression test to expose the problem and submit a pull
request?

In the mean time I'll see if I can get a Windows setup to test it on.

On 5 September 2012 08:01, MauritsMeijer notifications@github.com wrote:

sorry, it works in production, doesn't in development mode.


Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-8289401.

paul.serby@clock.co.uk
Chief Technology Officer

Direct: +44 2030 516115__Mobile: +44 7881 550999
*

*

@MauritsMeijer
Copy link
Author

I'll see what I can do

Op 5-9-2012 10:23, Paul Serby schreef:

Could you write a regression test to expose the problem and submit a pull
request?

In the mean time I'll see if I can get a Windows setup to test it on.

On 5 September 2012 08:01, MauritsMeijer notifications@github.com
wrote:

sorry, it works in production, doesn't in development mode.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/23#issuecomment-8289401.

paul.serby@clock.co.uk
Chief Technology Officer

Direct: +44 2030 516115__Mobile: +44 7881 550999
*

*


Reply to this email directly or view it on GitHub
#23 (comment).

@MauritsMeijer
Copy link
Author

It's the normalize path on line 131 that is causing the problem.
Removing it fixes that problem.

I can't get the testing stuff to work on Windows right now, so I'm gonna
pass on writing a test.

Op 5-9-2012 10:23, Paul Serby schreef:

Could you write a regression test to expose the problem and submit a pull
request?

In the mean time I'll see if I can get a Windows setup to test it on.

On 5 September 2012 08:01, MauritsMeijer notifications@github.com
wrote:

sorry, it works in production, doesn't in development mode.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/23#issuecomment-8289401.

paul.serby@clock.co.uk
Chief Technology Officer

Direct: +44 2030 516115__Mobile: +44 7881 550999
*

*


Reply to this email directly or view it on GitHub
#23 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants