Combine Map's Hash into one impl

serde-rs · Jun 25, 2024 · 51d94eb · 51d94eb
1 parent 5e7bedc
commit 51d94eb
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/src/map.rs b/src/map.rs
@@ -370,20 +370,19 @@ impl PartialEq for Map<String, Value> {
 
 impl Eq for Map<String, Value> {}
 
-#[cfg(not(feature = "preserve_order"))]
 impl Hash for Map<String, Value> {
-    #[inline]
     fn hash<H: Hasher>(&self, state: &mut H) {
-        self.map.hash(state);
-    }
-}
+        #[cfg(not(feature = "preserve_order"))]
+        {
+            self.map.hash(state);
+        }
 
-#[cfg(feature = "preserve_order")]
-impl Hash for Map<String, Value> {
-    fn hash<H: Hasher>(&self, state: &mut H) {
-        let mut kv = Vec::from_iter(&self.map);
-        kv.sort_unstable_by(|a, b| a.0.cmp(b.0));
-        kv.hash(state);
+        #[cfg(feature = "preserve_order")]
+        {
+            let mut kv = Vec::from_iter(&self.map);
+            kv.sort_unstable_by(|a, b| a.0.cmp(b.0));
+            kv.hash(state);
+        }
     }
 }