Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change serde_json::from_value to use pass-by-reference #1128

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Change serde_json::from_value to use pass-by-reference #1128

wants to merge 6 commits into from

Commits on May 1, 2024

  1. Use pass-by-reference when ownership is not needed

    @rooney
    rooney committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0ff9352 View commit details
    Browse the repository at this point in the history

  2. Fix test raw_value

    @rooney
    rooney committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1eac9e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Revert "Fix test raw_value" 

    This reverts commit 1eac9e3.
    @rooney
    rooney committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    48386d0 View commit details
    Browse the repository at this point in the history

  2. Revert "Use pass-by-reference when ownership is not needed" 

    This reverts commit 0ff9352.
    @rooney
    rooney committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ab1dbc7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into pass-by-ref

    @rooney
    rooney committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d7da524 View commit details
    Browse the repository at this point in the history

  4. Make from_value accepts &Value in addition to Value 

    This preserves backward compatibility while allowing code that needs to keep ownership of the Value to pass is as reference.
    @rooney
    rooney committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    94c5fd7 View commit details
    Browse the repository at this point in the history