Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i128 support #498

Closed

Conversation

macisamuele
Copy link

This fixes #487.

This PR adds support to 128-bits integers.
To avoid the introduction of a lot of boilerplate and code duplication I've modified the number::N to hold 128-bits integer.

I've not verified the whole library yet to ensure that all the integers flows are covered.
I opened this to have an initial feedback about the process.

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am closing the PR because I am not interested in changing the representation of Number or raising the minimum required Rust version. If a higher fixed precision Number type is required, I would recommend providing that in a separate library.

@rslife
Copy link

rslife commented Sep 20, 2019

Hello @dtolnay.

Now that almost a year has passed, would you be open to re-considering raising the minimum Rust version required?

Related issue: pyfisch/cbor#140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

impl as_u128/as_i128 for Number
3 participants