Skip to content

Update example to use Result<User, Box<dyn Error>> #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dtolnay merged 1 commit into from
Jan 10, 2021
Merged

Update example to use Result<User, Box<dyn Error>> #744

dtolnay merged 1 commit into from
Jan 10, 2021

Conversation

@Carreau
Copy link
Contributor

@Carreau Carreau commented Jan 10, 2021

This seem to be what is now expected on stable; as the compiler warnings are saying; and also consistent with what read_user_from_stream example is using.

@Carreau
Update example to use Result<User, Box<dyn Error>>
418507e 
This seem to be what is now expected on stable; as the compiler warnings are saying; and also consistent with what `read_user_from_stream` example is using.
dtolnay
dtolnay approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 7ff8ec6 into serde-rs:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Carreau @dtolnay