Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow parsing empty array into unit #869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jsen-
Copy link

@jsen- jsen- commented Mar 15, 2022

While working on JS <-> rust interop crate, I'm trying to serialize function arguments on the javascript side and deserialize into a tuple with appropriate number of elements on the rust side. Unfortunately I found that it doesn't work for functions with no arguments.

serde_json::from_str::<(u8,u8)>("[1, 2]").unwrap(); // is fine
serde_json::from_str::<(u8,)>("[1]").unwrap(); // is fine
serde_json::from_str::<()>("[]").unwrap(); // currently fails

This PR allows the last line to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant