impl Serialize and Deserialize for std::num::NonZero* #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
oli-obk
reviewed
Mar 24, 2018
serde/src/ser/impls.rs
Outdated
| where | ||
| S: Serializer, | ||
| { | ||
| self.clone().get().serialize(serializer) |
There was a problem hiding this comment.
I copied this from the generic NonZero<T> impl which does not assume T: Copy (get takes self by value), but these concrete types are indeed Copy so Clone is not necessary. I’ve removed it.
oli-obk
reviewed
Mar 24, 2018
serde/src/de/impls.rs
Outdated
| @@ -1934,6 +1935,39 @@ where | |||
| } | |||
| } | |||
|
|
|||
| macro_rules! nonzero_integers { | |||
| ( $( $T: ident, )+ ) => { | |||
| nonzero_integers!(@ $(::std::num::$T,)+); | |||
There was a problem hiding this comment.
The @ trick doesn't work on 1.13
There was a problem hiding this comment.
I’ve verified that it does if I swap the order of the macro’s two variants/patterns.
SimonSapin
force-pushed
the
nonzero
branch
3 times, most recently
from
a7ece65
to
f7d0354
Compare
|
On Travis: I think this is when running |
|
The clippy trouble is rust-lang/rust-clippy#2566. |
… gated on the `unstable` Cargo feature. These are new standard library types.
SimonSapin
added a commit
to servo/webrender
that referenced
this pull request
Mar 27, 2018
This will enable using serde-rs/serde#1191 in Servo
bors-servo
pushed a commit
to servo/webrender
that referenced
this pull request
Mar 27, 2018
WIP: Upgrade serde This will enable using serde-rs/serde#1191 in Servo <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2577) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/webrender
that referenced
this pull request
Mar 27, 2018
WIP: Upgrade serde This will enable using serde-rs/serde#1191 in Servo <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2577) <!-- Reviewable:end -->
SimonSapin
added a commit
to servo/webrender
that referenced
this pull request
Mar 27, 2018
This will enable using serde-rs/serde#1191 in Servo This includes a rebase of serde-rs/serde@master...Gankro:deserialize_from_enums4
bors-servo
pushed a commit
to servo/webrender
that referenced
this pull request
Mar 27, 2018
Upgrade serde This will enable using serde-rs/serde#1191 in Servo Includes a rebase of serde-rs/serde@master...Gankro:deserialize_from_enums4 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2577) <!-- Reviewable:end -->
SimonSapin
added a commit
to servo/webrender
that referenced
this pull request
Mar 27, 2018
This will enable using serde-rs/serde#1191 in Servo This includes a rebase of serde-rs/serde@master...Gankro:deserialize_from_enums4
bors-servo
pushed a commit
to servo/webrender
that referenced
this pull request
Mar 27, 2018
Upgrade serde This will enable using serde-rs/serde#1191 in Servo Includes a rebase of serde-rs/serde@master...Gankro:deserialize_from_enums4 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2577) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… gated on the
unstableCargo feature.These are new standard library types. Tracking issue: rust-lang/rust#49137