Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

has_flatten rework #2795

Merged
merged 5 commits into from
Aug 12, 2024
Merged

has_flatten rework #2795

merged 5 commits into from
Aug 12, 2024

Commits on Aug 11, 2024

  1. Fix creating and filling a collections that was not read

    @Mingun
    Mingun committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    0647a7c View commit details
    Browse the repository at this point in the history

  2. Correctly calculate has_flatten attribute in all cases for deserial… 

    …ization

Consequence: `FlattenSkipDeserializing[DenyUnknown]`
- does not collect data in Field, because do not read them anyway
- gets `deserialize_in_place` method
- gets ability to deserialize from sequence (visit_seq method)
- uses `deserialize_struct` instead of `deserialize_map`
    @Mingun
    Mingun committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    fd5b5e9 View commit details
    Browse the repository at this point in the history

  3. Fail with an understandable message is number of fields for serializa… 

    …tion is too many
    @Mingun
    Mingun committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    005cb84 View commit details
    Browse the repository at this point in the history

  4. Remove dead code - serialize_struct_as_map always called when cattrs.… 

    …has_flatten()==true
    @Mingun
    Mingun committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    547d843 View commit details
    Browse the repository at this point in the history

  5. Take into account only not skipped flatten fields when choose seriali… 

    …zation form

Consequence: `FlattenSkipSerializing`
- uses `serialize_struct` instead of `serialize_map`
    @Mingun
    Mingun committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    77a6a9d View commit details
    Browse the repository at this point in the history