Move Token De/Serializer to serde_test crate #412
Conversation
|
@oli-obk it would be best to review the commits individually - there are a few changes to make the API more presentable, especially around the Error variant and the assert_* functions. This is required for linked_hash_map to drop its dependency on serde_json: https://github.com/dtolnay/linked-hash-map/commit/dabca618762ed31b50bfa5ea92b5bbfc305d57c5?diff=split which is required for fixing serde-rs/json#91. |
|
Nevermind. The previous post has the motivation. reviewing now |
| @@ -0,0 +1,14 @@ | |||
| [package] | |||
| name = "serde_test" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
Since people are actually meant to use this crate, maybe we should sync versions with serde. Otherwise this becomes a piston-like mess
| } | ||
|
|
||
| fn cause(&self) -> Option<&error::Error> { | ||
| None |
There was a problem hiding this comment.
this was this way before the refactoring, but I wonder if it should forward to de::value::Error in case of ValueError?
There was a problem hiding this comment.
I got rid of ValueError in a later commit. Nothing was using ValueError.
|
lgtm For a public crate, the docs are very sparse. Also I'm not sure if the docs will be included in the automatically generated ones hosted by @erickt . Both issues can be addressed later. |
Fixes #411.