Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put rc impls behind a cfg #864

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Put rc impls behind a cfg #864

merged 1 commit into from
Apr 11, 2017

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Apr 11, 2017

Fixes #194. cc @shahn

@dtolnay dtolnay mentioned this pull request Apr 11, 2017
Closed
@dtolnay dtolnay merged commit ab82f09 into 1.0 Apr 11, 2017
@dtolnay dtolnay deleted the rc branch April 11, 2017 00:20
@nox
Copy link
Contributor

nox commented Apr 11, 2017

Wouldn't it be better to just document that people shouldn't expect that Rc<T> contents get reused after a roundtrip through serde?

@nox
Copy link
Contributor

nox commented Apr 11, 2017

This feature won't save anyone that uses serde and has a dependency that also uses serde with that feature enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtolnay @nox