Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facial area variables #86

Closed
serengil opened this issue Feb 28, 2024 · 1 comment
Closed

facial area variables #86

serengil opened this issue Feb 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@serengil
Copy link
Owner

In extract_faces function of retinaface, facial_area[2] should be x + w instead of w, and facial_area[3] should be y + h instead of h. So, variable names are not correct.

Ref: https://github.com/serengil/retinaface/blob/master/retinaface/RetinaFace.py#L248
@serengil serengil added the bug Something isn't working label Feb 28, 2024
@serengil serengil mentioned this issue Mar 2, 2024
Merged
@serengil
Copy link
Owner Author

serengil commented Mar 2, 2024

Closed with PR - #87

@serengil serengil closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serengil