correction in facial areas and expanding logic #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Comment on lines
+248
to
+249
| w = facial_area[2] - x | ||
| h = facial_area[3] - y |
There was a problem hiding this comment.
Is this a typo? I don't understand why that would be minus, and re-implementing with + instead of - works on my environment (with retina-face 0.0.15).
There was a problem hiding this comment.
Because 3rd and 4th points are x and y coordinates of right down area. We can find width and height by subtracting them to left up area coordinates.
There was a problem hiding this comment.
If you use plus, then you will have greater facial area. But it may exceeds the image coordinates and throw an exception. Correct calculation should be minus.
There was a problem hiding this comment.
Okay, thanks for the clarification!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets
#86
What has been done
With this PR, facial area variables x, y, w, h are set correctly.
How to test