Support "Curly Quotes" for Args.quoted

[dfontana]

Overview

Users on Mavericks+ Apple platforms (eg iOS) by default have their quote keys input "Curly Quotes" rather than straight quotes (also known as "Smart Quotes" or "Smart Punctuation"). This causes arguments to fail parsing, as it appears lexing checks against straight quotes only. While users could be asked to change their defaults, it's an abrasive experience that they may not wish to endeavor; and - at least on iOS - is a global setting they may not wish to change for this one use case.

Details

These Curly quotes appear to be unicode characters 201C and 201D.

Potential Solves

• Bot owners could check themselves, and alert the user -- kinda like the rust compiler. This won't be very graceful, however, and would probably introduce some complexity around argument count validation when using the macros.
• Args could be standardized to replace various known quote shapes with their straight line forms before passed into lexing, but this may have unintended consequences.
• The lexer function (linked earlier) could check for multiple quote styles; the major downsides being if these quotes were intermixed it could be tricky to get right. It might be fair to assume the two types would not be mixed (as so: "The “lazy” fox") or perhaps the first quote encountered can govern the style for the remainder of lexing.

Thoughts? I stumbled upon this in a guild with some friends, some of which use iPhone and others Android; some of whom are very not technical and it took some explaining to rectify what happened. But it's an annoying experience.

[arqunis]

I have opened #1553, which I have implemented per your third solution. Could you try it yourself if it works for your users? I have tested it myself by manually copying (I don't own an Apple device) the curly quote characters into an argument, which with my PR work the same as ".

[dfontana]

Oh awesome! I will gladly get this booted and test it, will report back

[dfontana]

Happy to report your branch does the trick 🎉 I was able to test on my iPad which has smart quotes, see image below inside the spoiler 😄 Thank you for this!

Image of Both