Apply changes to interaction response types and add a new interaction type #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
added
enhancement
arqunis
force-pushed
the
slash_commands_updates
branch
from
11be207 to
d276e8a
Compare
arqunis
force-pushed
the
slash_commands_updates
branch
from
d276e8a to
0cf8ca0
Compare
Flat
approved these changes
Mar 6, 2021
|
Sending embeds on an interaction response doesn't work with this PR (tested with https://github.com/acdenisSK/serenity/?branch=slash_commands_updates#0cf8ca025c2d8b73c2bca27eb11181e9b47b3bf4") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the interaction types to reflect the changes as laid in the slash commands UI changes pull request for Discord's API documentation: discord/discord-api-docs#2615.
This removes the
AcknowledgeandChannelMessageinteraction response types, as they have been deprecated and scheduled for removal on the 9th of April, and renamesAcknowledgeWithSourcetoDeferredChannelMessageWithSourceto suit a better purpose.Furthermore, a new
MessageInteractiontype and its correspondinginteractionfield inMessageis added.Additionally, a fix is incorporated to the interaction responses builders to use the correct field name for embeds (
embed->embeds).Type of Change
This is a breaking change that enhances the API to be up-to-date with Discord's API. However, as slash commands are locked behind a feature flag that states that they're an unstable feature, the breaking change can be excused and put on the
currentbranch.How Has This Been Tested?
This hasn't been tested yet, but according to the new documentation, it should work as intended.