Add audit log reason support to Http #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarmoGlace
suggested changes
May 22, 2021
| @@ -508,7 +513,7 @@ impl Member { | |||
| /// [Ban Members]: Permissions::BAN_MEMBERS | |||
| #[inline] | |||
| pub async fn unban(&self, http: impl AsRef<Http>) -> Result<()> { | |||
There was a problem hiding this comment.
Why don't you add support to the reason message here (and in others structures above)? Is it in WIP?
There was a problem hiding this comment.
This PR only adds audit log support to the Http client for simplicity. I will expand the explanation for this in the PR description, hopefully that will clear it up
arqunis
added
enhancement
arqunis
force-pushed
the
next
branch
3 times, most recently
from
7a56bbd to
d1d436e
Compare
kangalio
force-pushed
the
audit-log
branch
2 times, most recently
from
eda97c9 to
80fd30f
Compare
This adds support for parsing json with the `simd-json` crate for increased performance. However, it must be enabled with the `simd-json` feature flag, as not all processors support all SIMD instructions. In addition, the minimum-supported Rust version has been increased to 1.49.
Mainly the delete_XX methods because those apparently don't support audit log reasons (undocumented). And also in ban, because the ban reason overwrites any audit log reason
HarmoGlace
approved these changes
Jul 2, 2021
|
Can you resolve conflicts? Otherwise lgtm |
arqunis
approved these changes
Jul 2, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jul 2, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jul 2, 2021
HarmoGlace
pushed a commit
to HarmoGlace/serenity
that referenced
this pull request
Jul 4, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jul 11, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Aug 9, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Sep 8, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Sep 25, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Sep 30, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 29, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Nov 15, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Nov 15, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Dec 22, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Dec 23, 2021
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 23, 2022
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Mar 1, 2022
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Mar 15, 2022
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Apr 2, 2022
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second attempt at #296.
This PR only adds audit log reason support to the Http client. Model methods like
Member::unbanorGuildChannel::editstill cannot be provided with an audit log reason. This was done because:Option<&str>parameter to all the methods? That's a big breaking change and requires users to litterNonefunction arguments all over the placeI tested this by making a small test bot that invokes roughly half of all modified Http functions. The audit log in the server settings shows the correct reason strings. I couldn't test the other half of Http functions because I couldn't really figure out how to invoke them easily.
Unfortunately, Discord apparently doesn't properly document which HTTP routes support an audit log reason and which don't. I was using this table as a guideline, but probably there are some API routes where I falsely added or falsely omitted audit log support.