Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap ToString for Into<String> #1903

Merged
merged 3 commits into from
May 14, 2022
Merged

Swap ToString for Into<String> #1903

merged 3 commits into from
May 14, 2022

Conversation

GnomedDev
Copy link
Member

Fixes clippy::needless_pass_by_value... just straight up read down from https://canary.discord.com/channels/381880193251409931/673965002805477386/974396214244151377 on the serenity discord

@github-actions github-actions bot added builder Related to the `builder` module. examples Related to Serenity's examples. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate model Related to the `model` module. utils Related to the `utils` module. labels May 13, 2022
@arqunis arqunis added the enhancement An improvement to Serenity. label May 14, 2022
@arqunis arqunis merged commit 086a184 into serenity-rs:next May 14, 2022
@GnomedDev GnomedDev deleted the no-more-to_string branch May 14, 2022 12:53
nickelc pushed a commit that referenced this pull request May 25, 2022
@GnomedDev @nickelc
Switch to Into<String> when accepting string parameters (#1903)
f789baf 
This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
nickelc pushed a commit that referenced this pull request Jun 2, 2022
@GnomedDev @nickelc
Switch to Into<String> when accepting string parameters (#1903)
78e4d2b 
This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
@GnomedDev GnomedDev mentioned this pull request Jun 10, 2022
Merged
nickelc pushed a commit to nickelc/serenity that referenced this pull request Jun 11, 2022
@GnomedDev @nickelc
Switch to Into<String> when accepting string parameters (serenity-r…
1b88c84 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
nickelc pushed a commit to nickelc/serenity that referenced this pull request Jun 17, 2022
@GnomedDev @nickelc
Switch to Into<String> when accepting string parameters (serenity-r…
228f3c6 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
nickelc pushed a commit that referenced this pull request Jun 24, 2022
@GnomedDev @nickelc
Switch to Into<String> when accepting string parameters (#1903)
2786d03 
This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jul 20, 2022
@GnomedDev @arqunis
Switch to Into<String> when accepting string parameters (serenity-r…
eb82269 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Aug 21, 2022
@GnomedDev @arqunis
Switch to Into<String> when accepting string parameters (serenity-r…
7023a59 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Sep 2, 2022
@GnomedDev @arqunis
Switch to Into<String> when accepting string parameters (serenity-r…
dd17987 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
kangalio pushed a commit to kangalio/serenity that referenced this pull request Sep 11, 2022
@GnomedDev @kangalio
Switch to Into<String> when accepting string parameters (serenity-r…
0a97c12 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 1, 2022
@GnomedDev @mkrasnitski
Switch to Into<String> when accepting string parameters (serenity-r…
acda21c 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Nov 7, 2022
@GnomedDev @mkrasnitski
Switch to Into<String> when accepting string parameters (serenity-r…
5587ee6 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Nov 13, 2022
@GnomedDev @arqunis
Switch to Into<String> when accepting string parameters (serenity-r…
78f7cfb 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 28, 2023
@GnomedDev @mkrasnitski
Switch to Into<String> when accepting string parameters (serenity-r…
9ec4b78 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
@GnomedDev @mkrasnitski
Switch to Into<String> when accepting string parameters (serenity-r…
86d8cfc 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
@GnomedDev @mkrasnitski
Switch to Into<String> when accepting string parameters (serenity-r…
bc0fd4d 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@GnomedDev @mkrasnitski
Switch to Into<String> when accepting string parameters (serenity-r…
08f60c2 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@GnomedDev @mkrasnitski
Switch to Into<String> when accepting string parameters (serenity-r…
02999c5 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@GnomedDev @mkrasnitski
Switch to Into<String> when accepting string parameters (serenity-r…
ce1a152 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@GnomedDev @arqunis
Switch to Into<String> when accepting string parameters (serenity-r…
2b33b54 
…s#1903)

This changes instances of `ToString` to `Into<String>` whenever ownership of
the `String` is necessary. In case it is not, it's simply changed to `&str` to
lessen the effects of monomorphization on compile times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
builder Related to the `builder` module. enhancement An improvement to Serenity. examples Related to Serenity's examples. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis