Introduce a separate data type for autocomplete interactions #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickelc
added
enhancement
nickelc
force-pushed
the
interactions/autocomplete
branch
from
e431fbe to
dd29eba
Compare
The interaction payload for autocompletes is slightly different. It's
missing the `resolved` data map and reports only for the current
autocompleted option value the `focused` field and its value as a string.
The focused option value is modeled as an enum variant of `CommandDataOptionValue`.
```
enum CommandDataOptionValue {
Autocomplete { name: String, kind: CommandOptionType, value: String },
}
```
The focused option value can be retrieved via `AutocompleteData::focused_option()`
from the `AutocompleteData::options` vector.
nickelc
force-pushed
the
interactions/autocomplete
branch
from
dd29eba to
6dc482c
Compare
arqunis
approved these changes
Jun 6, 2022
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 6, 2022
…erenity-rs#1941)" This reverts commit f1048ca.
nickelc
added a commit
to nickelc/serenity
that referenced
this pull request
Jun 11, 2022
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
nickelc
added a commit
to nickelc/serenity
that referenced
this pull request
Jun 17, 2022
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 17, 2022
…erenity-rs#1941)" This reverts commit f1048ca.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 21, 2022
…erenity-rs#1941)" This reverts commit f1048ca.
nickelc
added a commit
that referenced
this pull request
Jun 24, 2022
The interaction payload for autocompletes is slightly different. It's
missing the `resolved` data map and reports only for the current
autocompleted option value the `focused` field and its value as a string.
The focused option value is modeled as an enum variant of `CommandDataOptionValue`.
```
enum CommandDataOptionValue {
Autocomplete { name: String, kind: CommandOptionType, value: String },
}
```
The focused option value can be retrieved via `AutocompleteData::focused_option()`
from the `AutocompleteData::options` vector.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 24, 2022
…erenity-rs#1941)" This reverts commit f1048ca.
nickelc
added a commit
to nickelc/serenity
that referenced
this pull request
Jul 4, 2022
…erenity-rs#1941)" This reverts commit 8ee4e39.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jul 16, 2022
…erenity-rs#1941)" This reverts commit f1048ca.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jul 20, 2022
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jul 24, 2022
…erenity-rs#1941)" This reverts commit f1048ca.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jul 25, 2022
…erenity-rs#1941)" This reverts commit f1048ca.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jul 30, 2022
…erenity-rs#1941)" This reverts commit f1048ca.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Aug 21, 2022
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Sep 2, 2022
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
kangalio
pushed a commit
to kangalio/serenity
that referenced
this pull request
Sep 11, 2022
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 1, 2022
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Nov 7, 2022
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Nov 13, 2022
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 28, 2023
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
…y-rs#1941) The interaction payload for autocompletes is slightly different. It's missing the `resolved` data map and reports only for the current autocompleted option value the `focused` field and its value as a string. The focused option value is modeled as an enum variant of `CommandDataOptionValue`. ``` enum CommandDataOptionValue { Autocomplete { name: String, kind: CommandOptionType, value: String }, } ``` The focused option value can be retrieved via `AutocompleteData::focused_option()` from the `AutocompleteData::options` vector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interaction payload for autocompletes is slightly different. It's
missing the
resolveddata map and reports only for the currentautocompleted option value the
focusedfield and its value as a string.The focused option value is modeled as an enum variant of
CommandDataOptionValue.The focused option value can be retrieved via
AutocompleteData::focused_option()from the
AutocompleteData::optionsvector.@kangalioo, you probably want to look into this because this will break
poisein the future.