Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify derive & #[non_exhaustive] attributes for number enums #1999

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Jun 20, 2022

BREAKING CHANGE: Some enums were missing the [non_exhaustive] attribute.

@nickelc nickelc added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jun 20, 2022
@github-actions github-actions bot added the model Related to the `model` module. label Jun 20, 2022
BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
@nickelc nickelc force-pushed the unify-enum-number-attributes branch from 840265d to 6d7dc91 Compare June 21, 2022 07:20
@nickelc nickelc merged commit 74edb88 into serenity-rs:next Jun 21, 2022
@nickelc nickelc deleted the unify-enum-number-attributes branch June 21, 2022 08:01
nickelc added a commit that referenced this pull request Jun 24, 2022
BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
nickelc added a commit to nickelc/serenity that referenced this pull request Jul 4, 2022
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
nickelc added a commit to nickelc/serenity that referenced this pull request Jul 4, 2022
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jul 20, 2022
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Aug 21, 2022
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Sep 2, 2022
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
kangalio pushed a commit to kangalio/serenity that referenced this pull request Sep 11, 2022
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 1, 2022
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Nov 7, 2022
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Nov 13, 2022
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 28, 2023
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
…enity-rs#1999)

BREAKING CHANGE: Some enums were missing the `[non_exhaustive]` attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant