Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MessageActivityKind variants upper camel case #2005

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Make MessageActivityKind variants upper camel case #2005

merged 1 commit into from
Jun 22, 2022

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Jun 22, 2022

One of these things is not like the other.
image

@nickelc nickelc added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jun 22, 2022
@github-actions github-actions bot added the model Related to the `model` module. label Jun 22, 2022
@jzeuzs
Copy link
Contributor

jzeuzs commented Jun 22, 2022

I think "upper camel case" is just PascalCase

@nickelc nickelc merged commit 49290d4 into serenity-rs:next Jun 22, 2022
@nickelc nickelc deleted the one-is-not-like-the-others branch June 22, 2022 15:21
nickelc added a commit that referenced this pull request Jun 24, 2022
@nickelc
Make MessageActivityKind's variants upper camel case (#2005)
0c8346f
nickelc added a commit to nickelc/serenity that referenced this pull request Jul 4, 2022
@nickelc
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
c497509 
)
nickelc added a commit to nickelc/serenity that referenced this pull request Jul 4, 2022
@nickelc
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
a6dbbb5 
)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jul 20, 2022
@nickelc @arqunis
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
edf0c36 
)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Aug 21, 2022
@nickelc @arqunis
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
ce02a3e 
)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Sep 2, 2022
@nickelc @arqunis
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
3a0b6fd 
)
kangalio pushed a commit to kangalio/serenity that referenced this pull request Sep 11, 2022
@nickelc @kangalio
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
248eb0e 
)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 1, 2022
@nickelc @mkrasnitski
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
c2485e6 
)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Nov 7, 2022
@nickelc @mkrasnitski
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
009c7aa 
)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Nov 13, 2022
@nickelc @arqunis
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
96eee8e 
)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 28, 2023
@nickelc @mkrasnitski
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
3f36078 
)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
@nickelc @mkrasnitski
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
e8321fa 
)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
@nickelc @mkrasnitski
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
e7a8b78 
)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@nickelc @mkrasnitski
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
c0ca302 
)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@nickelc @mkrasnitski
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
10c50c1 
)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@nickelc @mkrasnitski
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
4a53765 
)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@nickelc @arqunis
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
2ed4869 
)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@nickelc @arqunis
Make MessageActivityKind's variants upper camel case (serenity-rs#2005
b388e9b 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickelc @jzeuzs