Add more fields to MessageUpdateEvent #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cache
arqunis
requested changes
Sep 17, 2022
Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
arqunis
approved these changes
Sep 17, 2022
HarmoGlace
added a commit
to HarmoGlace/serenity
that referenced
this pull request
Oct 15, 2022
commit 3debed8beadc5c8e0bef5e43ee7b6a53450d7cfb
Author: kangalioo <jannik.a.schaper@web.de>
Date: Wed Oct 12 23:12:35 2022 +0200
Add missing Message fields (#2214)
New fields:
- `User::member`
- `Message::thread`
- `Message::application_id`
commit 67143ef33966aef5a949c2411d10a7d90d437382
Author: kangalioo <jannik.a.schaper@web.de>
Date: Fri Sep 30 17:56:45 2022 +0200
Deny Clippy warnings in CI (#2167)
commit b19f74d550d7f6f9b19626f27b6e926231b4bcaa
Author: kangalioo <jannik.a.schaper@web.de>
Date: Thu Sep 29 17:31:28 2022 +0200
Deny rustdoc lints in CI (#2183)
Both of those lints are warn-by-default, so all we need to do is deny warnings
in CI to catch documentation errors.
Setting those lints to deny always is quite annoying because if you're
developing, and quickly wanna check out the docs of your current state of work,
you're forced to fix up all links (context switch), which you would normally do
just once at the end of coding the pull request.
commit fe40de60cf946caead4faa416485a628586f7837
Author: kangalioo <jannik.a.schaper@web.de>
Date: Thu Sep 29 17:29:10 2022 +0200
Change `GatewayIntents::default()` to behave like `non_privileged()` (#2185)
commit 79e0bb5a60647190b0c3583e6133be0929d492ad
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Mon Sep 26 15:41:09 2022 -0400
Fix behaviour of `Guild::default_channel_guaranteed` (#2175)
This commit changes `Guild::default_channel_guaranteed` so that it
actually check that every member has access to a channel before
christening it the default guild channel. Also, ignore any members with
non-existent roles when checking for permissions.
commit e1bbe3309bdc87816331b9e5141bf47248fa1c19
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Fri Sep 23 12:09:50 2022 -0400
Band-aid fix `unused_async` clippy errors (#2174)
commit 30e6c84ef13c92d0f0e7d298be8f3ace5deff680
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Fri Sep 23 12:09:30 2022 -0400
Fix MSRV CI by pinning more dependencies (#2176)
commit dd09e0c71ca2ad439fc3a3867c118f4dc1ef151a
Author: Ivan <ivancernja@gmail.com>
Date: Tue Sep 20 17:32:47 2022 +0200
Change the link for shuttle.rs to the Github repository (#2171)
Co-authored-by: Ivan <ivan@Ivans-MacBook-Air.local>
commit 73a577d6ff07b10ea61c25bcf21e40d5e9d1b847
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sun Sep 18 16:00:57 2022 +0200
Put each command into its own file in example 14 (#2165)
commit 604cb79a9044a1212d394f1c295915df5ae1af70
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sun Sep 18 15:54:33 2022 +0200
Fix deprecation and clippy warnings (#2160)
commit 9824eb422c02e9152d7a297341645bb9335fa9dd
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sun Sep 18 15:53:28 2022 +0200
Mention `GUILDs` gateway intent required in `EventHandler::voice_state_update` (#2159)
commit 769c574d4365ed2d1b033fa83639440fa327d0f1
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sun Sep 18 15:52:18 2022 +0200
Fix `CreateEmbed::timestamp` documentation and example (#2158)
commit e885bea96dc59de257ddc137509f3c6f891a6dfa
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sun Sep 18 15:51:39 2022 +0200
Add proposed MSRV policy to README.md (#2157)
commit 96429aa8b1b6e44cfd7e825fef477d794fbf94d7
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 17 13:36:46 2022 +0200
Add more fields to `MessageUpdateEvent` (#2154)
commit 2eea7d792615c25ed904d08ec5931d935a314e9a
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 17 12:37:18 2022 +0200
Add note to `reaction_users` that emoji name is required (#2156)
commit 935f1b7c9f416645534b8dadeab09e135cfa825e
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 17 12:36:05 2022 +0200
Expose `Shard::handle_event` as part of the public API (#2155)
commit aa8bdd8662bf0ad4a52ed3800765a2f99b6578a9
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 17 12:21:02 2022 +0200
Move "does not work on ephemeral" to interaction delete (#2152)
commit ef69c08201c0530ad5e08e51ef2e32bd315a796b
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 17 12:19:01 2022 +0200
Remove claim that `Cache` implements `CacheHttp` and mention the full list of implementors (#2150)
commit 9bc53c7d7f6049c74c403917273cfa97a29b5838
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 17 12:16:19 2022 +0200
Remove claim that the default channel ID equals the guild ID (#2148)
commit 354108ec27f186050153197ded0f0dd3c3a536ff
Author: Alex M. M <acdenissk69@gmail.com>
Date: Fri Sep 16 22:15:31 2022 +0200
Mention shuttle.rs in a new 'Hosting' section of the README (#2143)
commit db60c0b804d123c40b68d70d56bfb01d43824dad
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Thu Sep 15 14:54:05 2022 -0400
Clarify MSRV requirements in README.md (#2141)
commit 9c352372db5d8194d525385afe58a1f2d09d604e
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 10 20:22:11 2022 +0200
Add event for HTTP ratelimits (#2136)
commit 791b01580352407e5f73859df369bdce640ca292
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 10 18:37:35 2022 +0200
Fall back to hardcoded gateway URL on `get_gateway` error (#2137)
commit bf93e7f7b14356716167efe065c057157be9c207
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 10 14:22:36 2022 +0200
Simplify example 17, add more comments, add emoji example (#2135)
commit 46ae1bc43e3f5c9c4b4e63ab2ad3e5009cd79e00
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Sat Sep 10 08:21:28 2022 -0400
Remove workaround for deserialization error in Scheduled Event endpoints (#2134)
commit 27d89a62e24601babb7478c7cb13ab57c37422c2
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 10 00:33:22 2022 +0200
Add Voice channels to the list of text-based channel types (#2133)
commit 82cb778373e8477a28097de1138277fd5f4a9649
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Sep 10 00:25:53 2022 +0200
Respect backslash in `standard_framework` quote parsing (#2132)
commit 5159c7dfed783aeda4a2c2dc25d593e97d5d8222
Author: kangalioo <jannik.a.schaper@web.de>
Date: Fri Sep 9 23:56:11 2022 +0200
Add Discord doc links to almost all model types (#2129)
commit a3ea47dd7c359fa5fb32357ab8592a02d8596d67
Author: Ben McKernan <ben-mckernan@users.noreply.github.com>
Date: Fri Sep 9 23:54:14 2022 +0200
Fix inaccessible guild scheduled event fields (#2124)
commit 5ce09940d1c07442876f70c742bf1bb74ac4c87f
Author: kangalioo <jannik.a.schaper@web.de>
Date: Fri Sep 9 23:53:55 2022 +0200
Implicitly set `BucketBuilder::await_ratelimits` to `1` upon `BucketBuilder::delay_action` being set (#2130)
commit 8b55ba32f0553fb0a81fe100f3c436b5a764cfcc
Author: kangalioo <jannik.a.schaper@web.de>
Date: Fri Sep 9 23:53:25 2022 +0200
Fix order of "direct message" and "server messages" (#2131)
commit 1835fec767a6d0e112c153facdc3853b05b35227
Author: kangalioo <jannik.a.schaper@web.de>
Date: Thu Sep 8 18:12:58 2022 +0200
Remove misleading sentence in docs (#2126)
commit b5314fefbe45fdc5e736400be23513d460b10559
Author: Fointard <9333398+Fointard@users.noreply.github.com>
Date: Tue Sep 6 23:33:56 2022 +0200
Fix missing await in sample code (#2122)
commit 2b254fd436c561a0234db5154f3d8fd7ec57a6e3
Author: kangalioo <jannik.a.schaper@web.de>
Date: Fri Sep 2 13:59:41 2022 +0200
Lookup user by ID globally in `ArgumentConvert` impl (#2115)
commit 67171db1fcad7d817ac19be45648cdfda150801f
Author: kangalioo <jannik.a.schaper@web.de>
Date: Thu Sep 1 16:54:22 2022 +0200
Implement `AsRef<Cache>` and `AsRef<Http>` for `CacheAndHttp` (#2114)
commit a48457a7659f3ef9a9c67c537368568a8e0745d9
Author: kangalioo <jannik.a.schaper@web.de>
Date: Thu Sep 1 15:32:27 2022 +0200
Do not discard deserialization error when Discord error JSON cannot be decoded (#2113)
commit 4694b36a6f50d3e857fed268085641d5bf0d1506
Author: Alex M. M <acdenissk69@gmail.com>
Date: Sun Aug 28 23:01:15 2022 +0200
Format
commit 3e8c12d21a887aec392751bf03d3c8618e08036f
Author: Alex M. M <acdenissk69@gmail.com>
Date: Wed Aug 24 23:37:09 2022 +0200
Remove codegen dependency on `futures` crate in `command_attr`
commit ec6b4b7fdeeb032eefeab423f1da18463e7cc77a
Author: Alex M. M <acdenissk69@gmail.com>
Date: Wed Aug 24 23:10:44 2022 +0200
Propagate all attributes in the `#[hook]` macro
This removes the concept of "cooked" attributes from hooks, which do not
benefit the distinction as the `#[command]` and `#[group]` macros do.
commit 6787b9cd53b39adffc181768eede68852b64eba4
Author: Nineko <45885710+NinekoTheCat@users.noreply.github.com>
Date: Fri Aug 19 04:42:55 2022 +0200
Fix `BucketBuilder::delay_action` being poorly documented (#2100)
commit b5d7973ad47a61a79225ddb4d59d6dbb3faa34f5
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Thu Aug 18 06:45:18 2022 -0400
Fix compilation of example 15 by pinning `notify` to 5.0.0-pre.14 (#2096)
commit 378f6345447fb174506f2affa5934f44c2541aa9
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sun Aug 7 15:37:56 2022 +0200
Rewrite automod tests from `serde_test` to comparing json (#2082)
commit ca6028b30d47ec6df3631db74c5a969e8ad78998
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Thu Aug 4 21:41:27 2022 +0100
Remove `#[must_use]` from `Typing::stop` (#2081)
commit d6475260771bd4e74f556bfc5f3dd66cbdec158e
Author: Polyhistorian <thefinnisharmy@gmail.com>
Date: Wed Aug 3 18:10:33 2022 +0300
Make `Timestamp` usable regardless of the `chrono` or `time` features (#2076)
This avoids a scenario where `Timestamp` could become useless if the user
disabled both the `chrono` and `time` features.
commit ce0f87b6ab5791c457e115f196cd1b85ca732a62
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Sat Jul 30 02:15:53 2022 -0400
Deprecate modifying command application permissions in bulk (#2077)
commit 4c9a61c227257ae0d65f6ce84c6b62fbccb59b84
Author: Alex M. M <acdenissk69@gmail.com>
Date: Fri Jul 29 17:33:11 2022 +0200
Bump to 0.11.5
commit 69484dc115cfa1fec15af5202c0d2f9f8b6ef949
Author: bumblepie <bumblepiebusiness@gmail.com>
Date: Wed Jul 27 10:46:46 2022 +1200
Make select menu values optional to fix deserialization of message component interactions (#2067)
commit 5363f2a8a362dc9bc210c9a87da985d43ab7faca
Author: Alex M. M <acdenissk69@gmail.com>
Date: Tue Jul 19 23:29:01 2022 +0200
Bump to 0.11.4
commit 54ed27fbd213920dec6165dc8f3786d90f41115d
Author: André Vennberg <andre.vennberg@gmail.com>
Date: Tue Jul 19 23:26:08 2022 +0200
Fix deserialization error of `GuildChannel::message_count` (#2060)
Every channel without a `message_count` field (i.e. all non-thread channels) would fail to deserialize.
This is fixed by adding `default` to the field, thus not attempting a deserialization if the field is missing.
commit 5c9b0af1322d3afc599e4689746a8efdcaf8419e
Author: Alex M. M <acdenissk69@gmail.com>
Date: Tue Jul 19 20:32:29 2022 +0200
Bump to 0.11.3 (#2059)
commit 06c031b4b4b2c1d204a24ae92359ba8fc12feec2
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Tue Jul 19 19:12:10 2022 +0100
Fix feature name casing (#2051)
commit 0a53345aa185e39b13d9db0f6e088f4fd03a0eea
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Tue Jul 19 18:11:50 2022 +0100
Temporarily fix `GuildChannel::message_count` in a non-breaking way (#2058)
commit b930895cdcef52a06d08b49ddc8ca239d2240f8b
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Jul 19 18:49:17 2022 +0200
Add support for `Auto Moderation` feature (#2035)
commit 46707e47ef1ece8cf13ca5ebbb273c706e464fe9
Author: nickelc <constantin.nickel@gmail.com>
Date: Thu Jul 14 13:11:03 2022 +0200
Add optional min/max length fields for application command string options (#2038)
commit 11918e74ab2eba7d61f94d5b5776d5546913adcd
Author: bumblepie <luke@bumblepie.space>
Date: Wed Jul 13 09:34:39 2022 +1200
Add name for "Manage Events" permission (#2046)
commit 24c02845a0e9e7bde38dacd84607de973ffec10f
Author: Alexis Paques <alexis.paques@gmail.com>
Date: Wed Jul 6 15:09:00 2022 +0000
Allow select menu response for modals (#1986)
commit c5cc876484232383c8cd1a7ce71c60624b86a75a
Author: Milo <50248166+Milo123459@users.noreply.github.com>
Date: Tue Jul 5 17:01:07 2022 +0000
Update `moka` to 0.9 (#2037)
From its change log:
> When using experimental `dash` cache, opting out of `sync` will reduce the number of dependencies.
Co-authored-by: nickelc <constantin.nickel@gmail.com>
commit ab406c1d6dba55965dfc614d78e77f142f892878
Author: nickelc <constantin.nickel@gmail.com>
Date: Sun Jul 3 18:42:23 2022 +0200
Remove superfluous link reference definitions for `crate::Error` (#2033)
The `Error` type is imported via `internal::prelude::*` and therefore
the link reference definitions aren't needed for the intra-doc link
resolution.
commit 28d215a63d6f470a193b6da7615a840219effec0
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat Jul 2 08:46:38 2022 +0200
Add `app_permissions` field on interactions (#2025)
The value is the computed permissions for a bot or app in the context of
a specific interaction (including any channel overwrites).
commit 4caa11042ef709cd4ea9775186f4e2eb8c23bbd8
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Thu Jun 30 02:38:54 2022 -0400
Enable `Invite::expires_at` field (#2026)
This field was originally left commented out because it depended on the
value of a query parameter that the `Http` method did not yet support,
and would therefore always be set `None`. That parameter has since been
added, so this field is useful now.
commit 35904b1aaabde304f6e1b75a0f957d82e184a0d2
Author: nickelc <constantin.nickel@gmail.com>
Date: Thu Jun 30 08:33:38 2022 +0200
Fix "missing field `discriminator`" serde error for presence updates (#2028)
commit b83eaa3b792a0f13893aa770f6ac97b76ae510f2
Author: Constantin Nickel <constantin.nickel@gmail.com>
Date: Wed Jun 29 14:26:07 2022 +0200
Merge `crate::builder` imports
rustfmt can't merge imports behind feature guards.
commit 7cec025afabd4e03cc40c9f350a779e81429aeee
Author: Constantin Nickel <constantin.nickel@gmail.com>
Date: Tue Jun 28 21:35:55 2022 +0200
Include example 18 in the makefile and CI job
commit ede89b994b3e8e5f4afec66ecb23242cb7074c91
Author: RuppFv <107818001+DRuppFv@users.noreply.github.com>
Date: Tue Jun 28 12:08:54 2022 -0300
Document example 16 (#2004)
Co-authored-by: Constantin Nickel <constantin.nickel@gmail.com>
commit c4dbea01716472675a4c1d29e3aedca2baca681b
Author: Andre Julius <noromoron@gmail.com>
Date: Tue Jun 28 17:07:28 2022 +0200
Add webhook example (#2006)
commit a2bd1e62ca803e329c29b702cdd2cf98621b7b51
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Tue Jun 28 16:06:19 2022 +0100
Introduce `rustversion` dependency and `backports` module (#2013)
This means, with the `collector` feature, Serenity now depends on `rustversion`
to conditionally compile depending on the Rust version. This commit starts off
using it to use the stdlib implementation of `retain_mut` if it is stable, or
fall back to our slower backport of it.
commit 9cf0c7a6d6b7e6b89995f94ca8246d9dce20d95c
Author: RuppFv <107818001+DRuppFv@users.noreply.github.com>
Date: Tue Jun 28 11:55:46 2022 -0300
Fix example 5's `say` command when no argument is given (#2010)
commit 7808d196e1b77a3a91fcf51c284e06c6f453d604
Author: Constantin Nickel <constantin.nickel@gmail.com>
Date: Thu Jun 23 20:31:57 2022 +0200
Add `MessageType::AutoModerationAction` enum variant
Co-authored-by: Gnome <david2005thomas@gmail.com>
commit 19c39a08dcbf5e58ac610e48e11081442e4f1079
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Thu Jun 23 15:36:47 2022 -0400
Attempt to fix lifetime bug around `CustomisedHelpData` (#2002)
This attempts to workaround a compiler bug around lifetimes that only
sometimes happens, and is solved by invoking `cargo clean`. See #2001.
commit dbf288a89346d9f5d5b245ab11213af631e3cc52
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Wed Jun 22 11:25:44 2022 -0400
Auto-impl `CacheHttp` for `Arc<T>` if `T` also implements it (#2003)
Removes a few manual implementations and replaces them with the
auto-impl. The assumption is that any extra indirections will be
optimized away.
commit a54495ec5b687508026e345e47c76741302aca2f
Author: RuppFv <107818001+DRuppFv@users.noreply.github.com>
Date: Wed Jun 22 10:26:43 2022 -0300
Count every "owo" word in messages in example 12 (#1998)
commit 5d27c8ba3f238eaf46959eb425446680d4a56932
Author: RuppFv <107818001+DRuppFv@users.noreply.github.com>
Date: Mon Jun 20 08:14:11 2022 -0300
Ignore the bot's own message when counting in example 12 (#1994)
Co-authored-by: Victoria Casasampere Fernandez <vickyf5124@gmail.com>
Co-authored-by: Constantin Nickel <constantin.nickel@gmail.com>
commit 29fb2e46311edfbc977d799d26971aa0d22e6404
Author: Constantin Nickel <constantin.nickel@gmail.com>
Date: Mon Jun 20 11:20:28 2022 +0200
Use `time` 0.3.9 for the MSRV build job
`time` 0.3.10+ MSRV is 1.57 + edition2021
commit 929feb6e83515230af6aa26d841706a3dc3e3036
Author: Diniz <107765721+DinizFv@users.noreply.github.com>
Date: Sat Jun 18 15:28:16 2022 -0300
Add missing `GUILDS` intent to example 13 (#1988)
This intent is required for the `cache_ready` event handler.
Co-authored-by: RuppFv <ruppfv@pop-os.localdomain>
commit 294d40a5f8c454e3a907237228ac25c6289b12fd
Author: Simon Zehetner <48550834+SimonZehetner@users.noreply.github.com>
Date: Sat Jun 18 13:04:09 2022 +0200
Fix minor spelling typos (#1985)
commit 071d1f54d811a7a029b2964f75ac5bda3fecadff
Author: nickelc <constantin.nickel@gmail.com>
Date: Fri Jun 17 11:24:32 2022 +0200
Fix clippy warnings & errors for all features enabled (#1982)
commit 43a7d495b63526baba8e2c3a0c8a354d35f6f9a0
Author: nickelc <constantin.nickel@gmail.com>
Date: Fri Jun 17 10:50:53 2022 +0200
Use `indexmap` 1.8.2 for the MSRV build job (#1983)
`indexmap` 1.9+ MSRV is 1.56 + edition2021
commit cbbdeb42f856f8c731ec2ad616ceb96b0e5a50b5
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Thu Jun 16 19:50:19 2022 +0100
De-duplicate base64 encoding (#1979)
commit bb7f1daccbbc235e37e29441586a0a53b1ec9ee9
Author: nickelc <constantin.nickel@gmail.com>
Date: Thu Jun 16 16:37:11 2022 +0200
Add audit log action types for scheduled events (#1978)
commit f9b4e9054250c11de059094e7f39573e2c3eca30
Author: Constantin Nickel <constantin.nickel@gmail.com>
Date: Thu Jun 16 13:31:41 2022 +0200
Use `Self` in enum matches
Replaces unnecessary repetitions of enum names when a replacement with
`Self` is applicable.
Missing bits from #1975
commit 1ef65f251b981674233b8f6d7edeefe9b92d7329
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Wed Jun 15 18:32:53 2022 +0100
Reuse `String` allocation in `reason_into_header` (#1973)
commit ce987c5910a697b045f51e9241a4936c77af1f35
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed Jun 15 19:32:00 2022 +0200
Use `Self` in enum matches (#1975)
Replaces unnecessary repetitions of enum names when a replacement with
`Self` is applicable.
commit 02bd028b0895a9692495e8094169781a8579f1ca
Author: kangalioo <jannik.a.schaper@web.de>
Date: Wed Jun 15 18:09:55 2022 +0200
Fill gaps in all `model::application` types (#1965)
- Add missing `autocomplete` and `*_localizations` fields
- Add Discord docs links to every model type
Co-authored-by: nickelc <constantin.nickel@gmail.com>
commit 68026567a943febeffd1cdbc4b402cd0810e0617
Author: Aaron Wilson <aawilson.iz.ssha@gmail.com>
Date: Tue Jun 14 05:26:57 2022 +0000
Fix a typo in example 02 (#1971)
commit b89d09636fe6667e7b9349fa88c76a96da95d471
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Fri Jun 10 21:11:49 2022 +0100
Remove unused `HashMap`s (#1954)
commit b9259e32a7cc1a2f6d7e45c7a141c8413345313d
Author: nickelc <constantin.nickel@gmail.com>
Date: Fri Jun 10 18:45:12 2022 +0200
Fix typo in the `EditGuild::discovery_splash` field (#1956)
commit ad756ee25bf8f5e921e20042b12c7fc7509d228d
Author: Constantin Nickel <constantin.nickel@gmail.com>
Date: Fri Jun 10 12:44:26 2022 +0200
Update `.git-blame-ignore-revs`
commit aafc1d04ac04fc9691d7bf56c1b4e8eb7cfd6597
Author: Constantin Nickel <constantin.nickel@gmail.com>
Date: Fri Jun 10 12:36:58 2022 +0200
Unify the rustfmt configurations
Groups the stable & unstable features and use the same configuration for
the `voice-model` crate.
commit b3f83cd871afbc9ca9356b67e713e3019d332057
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Tue Jun 7 16:50:05 2022 +0100
Remove duplication in `handle_event` (#1939)
commit a59db2362e5091757e5471e4779f2592e5dcfb55
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Mon Jun 6 17:44:54 2022 +0100
Fix clippy warnings caused by PR #1921 (#1948)
commit 362e48d261b6473eaad9955a0a7226a015e30762
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Mon Jun 6 17:05:07 2022 +0100
Fix unnecessary clone in `Message::react` (#1949)
commit beded13bcdac36f0e0418a5d30f578bd38c7407e
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Mon Jun 6 15:19:48 2022 +0100
Move `#[allow(clippy::unused_self)]` to only trigger of it (#1943)
commit 047d4ba057943e7e88cd2cd3eeedd353291818fb
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Mon Jun 6 15:19:16 2022 +0100
Rename "announcement channel" to "news channel" (#1944)
commit 62592e1e98d41ce1b26cbb8d8f3ea8c8e28a472e
Author: Constantin Nickel <constantin.nickel@gmail.com>
Date: Mon Jun 6 10:53:55 2022 +0200
Add missing quotation mark
commit f97322475eadf2dc78ea3e6d31b55811b3eb50ba
Author: kangalioo <jannik.a.schaper@web.de>
Date: Fri Jun 3 02:18:45 2022 +0200
Add support for slash command localization (#1921)
commit 62e2cd0f8e4386d19590382d2ce697afb0a614eb
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Thu Jun 2 20:23:58 2022 +0100
Implement announcement channel following (#1900)
commit 3ef293cefdfe73927c4bfc27e1ee139c11dd7384
Author: FallenWarrior2k <mail@fallenwarrior.me>
Date: Thu Jun 2 18:41:47 2022 +0200
Fix compile errors in builders when the `model` feature is disabled (#1931)
commit 8d71248db9efe44ca482cf4faaacc42f6cce072b
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Wed Jun 1 15:31:17 2022 +0100
Fix non-breaking clippy warnings (#1909)
commit d243eecf5ef134ccd98597ee7f5499c2373e3fa2
Author: Alex M. M <acdenissk69@gmail.com>
Date: Tue May 31 03:47:14 2022 +0200
Fix dates for versions released this year
commit ecff03ed4bc313005a8c5885082b0dabce23cf43
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue May 31 01:02:32 2022 +0200
Add event handler methods for scheduled events (#1918)
Gateway events:
- `GUILD_SCHEDULED_EVENT_CREATE`
- `GUILD_SCHEDULED_EVENT_UPDATE`
- `GUILD_SCHEDULED_EVENT_DELETE`
- `GUILD_SCHEDULED_EVENT_USER_ADD`
- `GUILD_SCHEDULED_EVENT_USER_REMOVE`
commit d57450c1e932280962e13ed3eed2dd9c50d503c9
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue May 31 01:01:00 2022 +0200
Use `#[serde(default)]` for the `ScheduledEventMetadata::location` field (#1916)
This field is optional and isn't sent for stage & voice events when the
metadata is sent for gateway events in some circumstances.
Adding `#[serde(default)]` is a workaround instead of changing it to
`Option<String>`.
commit 5eb6118ff7dfe0d801dab43225a5fedad9dfb913
Author: Alex M. M <acdenissk69@gmail.com>
Date: Sat May 28 00:34:52 2022 +0200
Add missing reactions intent to example 10
Without this intent, the `challenge` command will not work, as it will
be unable to collect reaction events.
commit 037fff429281a8ecb8024d5fe247c5aba9abb4d7
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed May 25 16:36:24 2022 +0200
Ignore doctests on non-exported `macro_rules!` (#1914)
Non-exported `macro_rules!` are now included in the `doctest` target but
cannot test the macro.
```
error: cannot find macro `generate_get_permission_names` in this scope
--> src/model/permissions.rs:59:1
```
commit de74b79af73aeb68f0c24800e9cc56fc7fce1057
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue May 24 15:47:09 2022 +0200
Remove unused macro rules (#1913)
commit 4f10b9d10b5f2703475d68d128edf853fb0bdb1a
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue May 24 15:44:37 2022 +0200
Remove `guild_id` insertion for the `PartialChannel` deserialization (#1912)
The `resolved` data map is using the `PartialChannel` struct which has no `guild_id` field.
commit 0f9c77ac40ec84add4f7d761b1f07c6502a5f350
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat May 21 17:31:14 2022 +0200
Replace magic number for interaction response type (#1907)
commit 1eee3dac5d28ff69b2010e3a622ee3b2426e1bce
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Tue May 17 08:59:46 2022 -0400
Add methods to `Webhook` to enable direct creation (#1904)
This adds `Webhook::{from_id, from_id_with_token, from_url}` that wrap the
equivalent methods on `Http`. These take the same parameters as the
methods they wrap, plus an additional `http` parameter.
commit f82a16dae0c5b1910598115b264a66fb8182a340
Author: nickelc <constantin.nickel@gmail.com>
Date: Fri May 13 16:42:14 2022 +0200
Replace intradoc links to deprecated types (#1901)
commit c9286b14136128f68e2f4a44859e3bec21fa9de6
Author: nickelc <constantin.nickel@gmail.com>
Date: Thu May 12 22:51:35 2022 +0200
Consolidate `interactions` & `oauth2` model types into the `application` module (#1899)
* Move `model::oauth2::OAuth2Scope` into `model::application::oauth`
`OAuth2Scope` is moved and renamed to `model::application::oauth::Scope`.
Previous export is deprecated.
* Move application command types into the `model::application::command` module
The model types for managing application commands are moved from
`interactions::application_command` into the `application::command` module.
The types are also renamed to reduce repetitive module names in the type names.
- `ApplicationCommand` -> `Command`
- `ApplicationCommandType` -> `CommandType`
- `ApplicationCommandOption` -> `CommandOption`
- `ApplicationCommandOptionType` -> `CommandOptionType`
- `ApplicationCommandOptionChoice` -> `CommandOptionChoice`
- `ApplicationCommandPermission` -> `CommandPermission`
- `ApplicationCommandPermissionData` -> `CommandPermissionData`
- `ApplicationCommandPermissionType` -> `CommandPermissionType`
Deprecated types aliases are kept in the original module.
* Move message component types into the `model::application::component` module
The model types for message components are moved from
`interactions::message_component` into the `application::component` module.
Deprecated type aliases are kept in the original module.
* Move interaction types into the `model::application::interaction` module
Some types are also renamed to reduce repetitive module names in the type names.
Module: `model::interactions` -> `model::application::interaction`
- `InteractionApplicationCommandCallbackDataFlags` -> `MessageFlags`
Module: `model::interactions::application_command` -> `model::application::interaction::application_command`
- `ApplicationCommandInteractionData` -> `CommandData`
- `ApplicationCommandInteractionDataOption` -> `CommandDataOption`
- `ApplicationCommandInteractionDataResolved` -> `CommandDataResolved`
- `ApplicationCommandInteractionDataOptionValue` -> `CommandDataOptionValue`
Deprecated type aliases are kept in the original module.
commit 502fc8d6515d960fdb064acb1893c2d8f4e4efe9
Author: Alex M. M <acdenissk69@gmail.com>
Date: Sun May 8 17:24:12 2022 +0200
Bump to 0.11.2 (#1898)
This release is primarily focused on optimisations/simplifications of the codebase to improve its quality and to compile and run faster, and in general remove unneeded cruft. It also contains a few additions, like:
- Support for the `SUPPRESS_EMBEDS` flag.
- Scheduled events support.
- Conversion from `Guild` to `PartialGuild`.
- `PartialOrd` and `Ord` trait implemnentations for `Timestamp`.
- V2 application command permission support.
commit 39fb310247e609ef7baa91fbe34493e16471372b
Author: ElKowar <5300871+elkowar@users.noreply.github.com>
Date: Sun May 8 16:22:11 2022 +0200
Split up a few functions to minimize monomorphization-bloat (#1894)
Splitting up the large and commonly used functions `ChannelId::send_message`,
`Message::edit`, `ApplicationCommandInteraction::create_interaction_response`
and `create_followup_message` to minimize the length of the function
that is generic over the closure argument.
In most cases, closures count as unique types, and thus every use of
these functions can cause a new copy of that function to be generated
during monomorphization.
By moving most of the function bodies into separate, non-generic functions,
we can minimize the impact of this monomorphization-bloat.
Co-authored-by: nickelc <constantin.nickel@gmail.com>
Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
commit dc22cf2af034e521e11971af8f8cda0066d6a87a
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Thu May 5 21:26:53 2022 +0100
Adapt the library to pass the majority of `clippy::pedantic` lints (#1886)
commit e690ccd17174f2b9dc3f6a1545f69a209a11241f
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Wed May 4 13:35:40 2022 -0400
Implement Guild Scheduled Events support (#1884)
This adds a `ScheduledEvent` struct along with a few helper structs and a
`ScheduledEventId` type. Also implements the Get Scheduled Event(s)
APIs, and adds a missing `MANAGE_EVENTS` permission.
This also adds requisite builders for creating and editing scheduled events, and
includes a (hopefully temporary) fix to error deserialization as a
workaround to a bug in the API.
Lastly, this adds a `ScheduledEventUser` struct, and adds two methods each to `Guild`
and `GuildId`. The first, `scheduled_event_users`, only takes an
optional limit parameter. The second, `scheduled_event_users_optioned`,
can take additional pagination parameters.
commit bca105a0b9bca26d272ddab5c8b99fd93517cbf6
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed May 4 19:31:08 2022 +0200
Add initial application command permissions v2 support (#1880)
This adds the `EventHandler::application_command_permissions_update`
method for handling the new gateway event when an application command's
permissions are updated.
This also adds new fields & methods to `ApplicationCommand` and its builder
to specify default permissions required to execute the command and if
the command is available in DMs.
See:
- `ApplicationCommand::default_member_permissions`
- `ApplicationCommand::dm_permission`
- `CreateApplicationCommand::default_member_permissions`
- `CreateApplicationCommand::dm_permission`
New enum variant `ApplicationCommandPermissionType::Channel`
commit 2f8e2b09479a4b5d466e7c89ccba04346729219a
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue May 3 23:37:26 2022 +0200
Remove unnecessary braces in use statement (#1890)
commit e1eaeeb2dcf493cd64f6765bf88e5430b22f81e2
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue May 3 21:26:37 2022 +0200
Fix wrong ID type in doc comment (#1888)
commit 0a544c645995c5c8f9cddb0e6240bdb8854bd24b
Author: kangalioo <jannik.a.schaper@web.de>
Date: Tue May 3 21:26:26 2022 +0200
Strip leading "Bot " in parse_token (#1889)
commit 3e454cc50dfa290d07ea36ad058fd59355c9ff46
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue May 3 15:11:04 2022 +0200
Replace feature gated `simd-json` trait imports with `json::prelude::*` (#1887)
commit 97ef906b349c400141104602944186a977a75414
Author: nickelc <constantin.nickel@gmail.com>
Date: Mon May 2 17:57:41 2022 +0200
Remove unused code related to the former voice functionality (#1883)
commit 8b2326c7523b74d4da39881b30a3a62f7411360d
Author: Steven Mak <14815068+MelonShooter@users.noreply.github.com>
Date: Sun May 1 14:24:43 2022 -0700
Improve binary message deserialization time by optimizing `convert_ws_message` (#1871)
commit b1c3a62161a640b7c11a39797d03697e6a4e2ff5
Author: Ted Tramonte <ted.tramonte+github@gmail.com>
Date: Sun May 1 17:20:33 2022 -0400
Implement `Ord` and `PartialOrd` for `Timestamp` (#1882)
Closes #1881
Co-authored-by: nickelc <constantin.nickel@gmail.com>
commit be1775240b0739d60653453a16d990500a945b11
Author: nickelc <constantin.nickel@gmail.com>
Date: Sun May 1 19:43:58 2022 +0200
Remove duplicate WS client creation for native/rustls backends (#1879)
The creation of the websocket client for both tls backends is identical
and can be merged into a single code path.
commit 79a3cc85bd014f285c753f370963823c4220ba72
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Sat Apr 30 15:35:47 2022 -0400
Use `Cow` in `utils/content_safe.rs` to save on allocations (#1876)
Some unnecessary allocations were being done converting `&'static str` to
`String` in `clean_mention`. Changing the return type to `Cow` lets us
avoid these.
commit 2898af206e9ee6fdc383c5b00d876a8bf4b4b2d1
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat Apr 30 16:15:53 2022 +0200
Use `dashmap` 5.2.0 for the MSRV build job (#1878)
`dashmap` 5.3+ MSRV is 1.59 and depends on `hashbrown` 0.12 (MSRV 1.56 + edition2021)
commit b2ae872f7eba793c06370a58f59e60caceb59d66
Author: nickelc <constantin.nickel@gmail.com>
Date: Thu Apr 28 20:54:14 2022 +0200
Add new enum variant to `audit_log::Action` to represent unknown values (#1875)
This fixes the deserialization issue for unknown action type values.
commit 0450ddebb541dc5e9cef625b964cf8497b0d6cb7
Author: Alex M. M <acdenissk69@gmail.com>
Date: Wed Apr 27 11:25:15 2022 +0200
Remove unused `chrono` dependency in example 09
It is used indirectly via the `Timestamp` type.
commit 888c37f044df92b1768661079385bdb1a09e2034
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed Apr 27 00:47:41 2022 +0200
Add `SUPPRESS_EMBEDS` flag for interaction response messages (#1873)
commit dd9d2556cde3a4df0b2b434733fd355e9d4b5de5
Author: kangalioo <jannik.a.schaper@web.de>
Date: Wed Apr 27 00:47:14 2022 +0200
Fix lifetimes on interaction response methods (#1874)
commit 0ba01a73a25c98c5c32025e60ca15fdd21d7062b
Author: nickelc <constantin.nickel@gmail.com>
Date: Mon Apr 25 17:02:11 2022 +0200
Update `simd-json` to 0.4.14 (#1872)
This version includes a fix for a deserialization issue with newtype
structs and `simd_json::value::owned::Value`.
The ID types and `utils::Colour` deserialization fails on gateway
events because the payload is deserialized as `json::Value` before it is
deserialized into the actual type.
commit 47433de14f1ef5fd98662bab7e699c187d73fddc
Author: nickelc <constantin.nickel@gmail.com>
Date: Mon Apr 25 08:05:58 2022 +0200
Optimize guild create & delete event deserialization (#1870)
The `json::Value` can be used directly without deserializing it to `json::JsonMap`.
commit 10d9297dda9aaa43a02b299ea6e4b05e7ca044d2
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat Apr 23 20:44:16 2022 +0200
Add function for interaction followup messages to set or unset the ephemeral flag (#1868)
commit c3ad0b2c49aeecddf7f28e324cf35c782245360e
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Sat Apr 23 14:43:56 2022 -0400
Use `AttachmentType::data` in `EditRole::icon` (#1867)
Instead of manually resolving the data, use existing methods which
accomplish the same thing.
commit 475fc1fb1523f3d46b0119c2ba7e9fc1b4b43bfa
Author: kangalioo <jannik.a.schaper@web.de>
Date: Sat Apr 23 20:43:04 2022 +0200
Implement conversion from `Guild` to `PartialGuild` (#1865)
commit 889540a0f336cbe23940acf11b17d2324e6f2a6a
Author: Alex M. M <acdenissk69@gmail.com>
Date: Sat Apr 23 17:45:11 2022 +0200
Use the full message when no delimiters are specified
commit 628c1ead2c7d091d689a57ca8b44a74594a97db7
Author: Alex M. M <acdenissk69@gmail.com>
Date: Sat Apr 23 15:16:36 2022 +0200
Fix argument parsing when no delimiters are specified
commit b1cc7022228608563e815c3f82b971d5ca6bfc74
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Apr 19 18:24:09 2022 +0200
Fix unused import and deny unused items (#1863)
commit 56293bbef371e84a183ea413d77d44106578ee57
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Apr 19 16:50:07 2022 +0200
Deny broken and private intra doc links (#1862)
commit fe53b1681e80386bbb8b9b9e341926504748118e
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Apr 19 13:54:31 2022 +0200
Fix broken links in the readme (#1861)
commit 75df53e58fe591525ffdf726dcca3564d06cafdf
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Apr 19 13:21:52 2022 +0200
Update `.git-blame-ignore-revs` (#1860)
Ignores: 4c97810b6d25617fa0a0a4b4769deb751a17d373
commit c83ba2a1d61bf8e29638da26bab9f94dd0d90c0f
Author: Alex M. M <acdenissk69@gmail.com>
Date: Mon Apr 18 23:00:21 2022 +0200
Bump to v0.11.1
commit 9f11a3f2e9908ae33b3ab0dbd38ccf7fb96370ba
Author: Alex M. M <acdenissk69@gmail.com>
Date: Mon Apr 18 22:57:28 2022 +0200
Manually specify list of features for docs.rs to build
commit 4fc1b37c0f52d56d39f4c061deed7b78865b7f0e
Author: Alex M. M <acdenissk69@gmail.com>
Date: Mon Apr 18 22:21:11 2022 +0200
Bump to 0.11.0 (#1774)
This marks the end of the `v0.10.x` series and the beginning of the `v0.11.x` series.
It includes a multitude of breaking changes, small and huge, and lots more of other
additions, fixes, and removals.
Notable changes include:
- Removal of deprecated and unused things
- Removal of tokio `0.2` compatiblity
- Changing the cache to be synchronous
- Increasing the MSRV to 1.53
- Reorganisation of types into separate modules
- Improving perfomance and quality of deserialise implementations
- Requiring specifying gateway intents
- Making `chrono` an optional dependency (but is still turned on by default)
- Simplifying the `Http` API
- Stabilising application commands (i.e. `unstable_discord_api` is no longer necessary)
- Support for attachments when creating and updating followup messages
commit fbfe0cf8337db4854778a38bba79c3fd0427ebdf
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Mon Apr 18 12:37:13 2022 -0400
Use `str::split_once` for parsing webhooks and user tags (#1795)
Now that Serenity's MSRV is on 1.53, we can replace some parsing logic
with `str::split_once` for better maintainability/readability.
commit 32cb31c39b736ac3df4464d688c438dce195a7d0
Author: Michael Krasnitski <michael.krasnitski@gmail.com>
Date: Sun Apr 10 15:04:21 2022 -0400
Refactor and fix bugs in `utils::content_safe`
Adds an impl of `Mentionalble` for `EmojiIdentifier`.
Furthermore, implements `FromStr` for `Mention`, and removes
`utils::parse_mention` since it's no longer used. This impl is used to
refactor `content_safe()`, and fix a subtle bug caused by parsing
between outer-most pairs of angle brackets instead of inner-most pairs,
which could allow maliciously-crafted input to bypass the filter.
NOTE: Before, mentions that were all-numeric but were too big to fit
into a `u64` would still be cleaned, but as the server ignores these
anyway, the parsing behaviour now ignores them as well. Test cases are
modified to accomodate these new changes.
commit f5458f104c0e6508db2f72b279e5829ccfaacb8e
Author: Michael Krasnitski <michael.krasnitski@gmail.com>
Date: Tue Apr 5 16:55:35 2022 -0400
Move `misc::Mention{able}` into their own `model/mention` module
commit d245e67e4b36e1cdec8cf1d845895644069d672b
Author: kangalioo <jannik.a.schaper@web.de>
Date: Mon Apr 18 18:32:48 2022 +0200
Require setting gateway intents explicitly (#1817)
commit 2596927be68466412428d299c94ea630f0c1c999
Author: nickelc <constantin.nickel@gmail.com>
Date: Thu Apr 14 23:30:09 2022 +0200
Remove the `Error::Num` enum variant (#1847)
The enum variant was used while `User::discriminator` was mapped as a
string and `User::default_avatar_url` return type was `Result<String>`.
commit 10410a205b1841f5feab7b0a35c051feaffb9b0f
Author: Tomio <mail@tomio.codes>
Date: Fri Apr 15 05:29:54 2022 +0800
Update methods and properties of `Permissions` (#1849)
commit d3ae156cb80cebda36f2e5a5003dad30825a086e
Author: nickelc <constantin.nickel@gmail.com>
Date: Thu Apr 14 23:28:54 2022 +0200
Fix minor issues with doc comments & examples (#1850)
commit f4f310ddeef04c0e7aefa064dea9dd7fd324d0df
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Tue Apr 12 04:23:27 2022 +0200
Pass parsed token to `Ratelimiter::new()` (#1848)
Fixes a regression caused by #1840 where `Ratelimiter::new()` receives
the original token instead of the one prefixed with `Bot`.
commit f8bc937b4c8a50d9ab4aefa95ef5b45fab090edf
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Mon Apr 11 19:32:45 2022 +0200
Simplify constructor functions for `Http` (#1840)
This commit aims to clean up the different methods for creating a new `Http`
instance.
Removals:
- `Http::new()`: Providing your own `reqwest` client seems like a niche use
case where you can use `HttpBuilder` instead
- `Http::new_with_application_id()`: Creates an HTTP client without a token, so
you won't be able to use it anyway
- `Http::default()`: Same as above
Renames:
- `Http::new_with_token()` -> `Http::new()`
- `Http::new_with_token_application_id()` -> `Http::new_with_application_id()`
Co-authored-by: Constantin Nickel <constantin.nickel@gmail.com>
commit a36353b45f50ded4d05c4f9895fd0b089d841355
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Mon Apr 11 19:28:08 2022 +0200
Remove unnecessary `CacheHttp` requirements (#1841)
This removes the `CacheHttp` requirement for parameters where only the cache is used.
commit 6028072098a31874fe6059d0001d2a152374acc9
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Mon Apr 11 13:27:08 2022 -0400
Update documentation around webhook components (#1844)
Clarify the conditions for when webhooks are able to correctly use
message components.
commit d7ef273683ac6751b35499505c31da847bf089f3
Author: nickelc <constantin.nickel@gmail.com>
Date: Mon Apr 11 19:26:40 2022 +0200
Remove redundant `ClientBuilder::application_id` field (#1839)
The field was used to return the ID as `ApplicationId` but it can also be
received from `Http` and mapped to `ApplicationId`.
commit 8d3a079f136dbdd5c640dc19262061551c81484c
Author: nickelc <constantin.nickel@gmail.com>
Date: Mon Apr 11 19:25:57 2022 +0200
Remove the `Error::Rustls` enum variant (#1845)
This error variant is no longer needed since the asynchronous
refactoring and is now covered by the `Error::Tungstenite` variant.
commit 4c97810b6d25617fa0a0a4b4769deb751a17d373
Author: nickelc <constantin.nickel@gmail.com>
Date: Mon Apr 11 17:38:36 2022 +0200
Format imports with module granularity (#1846)
This improves the readability and grepability of the imports.
commit e283b514428c90c7297b0499397ae2f62805541f
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Mon Apr 11 10:33:37 2022 +0200
Remove unused `found_group_prefix` parameter (#1842)
commit 1dbe9f1d839bd3999286c89daabdedc90214e407
Author: nickelc <constantin.nickel@gmail.com>
Date: Sun Apr 10 17:43:22 2022 +0200
Fix compilation error (#1838)
commit c5f9cbe731be96aed622838946bf726bad552c6d
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Sun Apr 10 14:57:58 2022 +0200
Set `Http::application_id` in ready event handler (#1772)
commit 440f0fa5204b00ea3200ee3577d1c051862a6041
Author: nickelc <constantin.nickel@gmail.com>
Date: Sun Apr 10 14:56:22 2022 +0200
Add build job to test the `native-tls` backend (#1837)
commit f6a3700e89b3dc889aa2a4bf285fb79850b3d8ba
Author: nickelc <constantin.nickel@gmail.com>
Date: Sun Apr 10 14:54:05 2022 +0200
Fix clippy warnings suggested by `clippy::pedantic` (#1830)
- `clippy::string_add_assign`
- allow `clippy::trivially_copy_pass_by_ref` on `serialize` functions
- `clippy::redundant_else`
- `clippy::single_match_else`
- `clippy::redundant_closure_for_method_calls`
- `clippy::semicolon_if_nothing_returned`
- `clippy::map_unwrap_or`
- `clippy::ref_binding_to_reference`
- `clippy::if_not_else`
- `clippy::inefficient_to_string`
- `clippy::cloned_instead_of_copied`
- `clippy::needless_pass_by_value`
- `clippy::match_same_arms`
- `clippy::flat_map_option`
- `clippy::explicit_into_iter_loop`
- `clippy::trait_duplication_in_bounds`
- `clippy::items_after_statements`
- `clippy::default_trait_access`
- `clippy::needless_question_mark`
- `clippy::single_match`
- `clippy::explicit_iter_loop`
commit 81a9bc2d0b2e179c354192caf23109d501430fc3
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Sun Apr 10 14:50:09 2022 +0200
Switch to using URL over URI (#1836)
**BREAKING CHANGE**:
The `Client::ws_uri` field has been renamed to `ws_url`.
commit 4dbf3d06beaec57e1d235f0469907a5a61a02b04
Author: nickelc <constantin.nickel@gmail.com>
Date: Sun Apr 10 14:48:00 2022 +0200
Add new command data field `guild_id` (#1833)
This field represents the ID of the guild the command is registered to.
commit c2b94459e831558c7d0250777e33155b13dc5d2a
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Sun Apr 10 14:29:57 2022 +0200
Remove unused `update_cache_timeout` from `CacheAndHttp` (#1835)
The field is no longer in use since the asynchronous refactoring.
commit 16661a3abf4786ada95db095a0847a93842c51f3
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Sun Apr 10 11:05:45 2022 +0200
Remove `*tls_backend_marker` features (#1834)
The markers are remnants of the removed tokio 0.2 compatibility
commit 3b99eebe1c40ab00ca416c68103c5b1a53eb437a
Author: nickelc <constantin.nickel@gmail.com>
Date: Thu Apr 7 23:49:30 2022 +0200
Add new "Directory" channel type (#1825)
commit c5dc80bc1642de2a87ce4a2a7f8f28db44c16c11
Author: nickelc <constantin.nickel@gmail.com>
Date: Thu Apr 7 23:49:02 2022 +0200
Deserialize the interaction data's `target_id` unconditionally (#1826)
This was part of the code for the generated `target` field, which is now
a method.
commit 404ab03d4d6fdc1f57daea0e5876fa300029f868
Author: nickelc <constantin.nickel@gmail.com>
Date: Thu Apr 7 23:45:49 2022 +0200
Reduce size of the `ResolvedTarget` enum variants (#1827)
This fixes the `clippy::large_enum_variant` warning for both variants
(`Message` 1000 bytes / `User` 328 bytes).
commit 977946f217d711bbb6958968f011184a09d97e0e
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Apr 5 23:18:03 2022 +0200
Change matches where the match expression is a bool to be more idiomatic (#1823)
This changes the deserialization pattern of `match map.contains_key(key)` followed by
`map.remove(key).ok_or_else(|| "expected key"). ...` if the key exists.
commit 8b21193ff61718745018c0245a9048a1ec2f3797
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Apr 5 23:17:26 2022 +0200
Remove the store channel type from `Channel` deserialization (#1824)
commit d03809f43f62f79060b1ec1b2a5edb5084128a1e
Author: Alex M. M <acdenissk69@gmail.com>
Date: Tue Apr 5 21:34:20 2022 +0200
Place temporary caching functionality under a separate feature flag (#1813)
commit e69bcd3d06091f6328dcab8ed61ec23d255a6c0f
Author: Konrad Borowski <konrad@borowski.pw>
Date: Tue Apr 5 21:11:04 2022 +0200
Make chrono a default optional feature (#1804)
commit 5a0e8f436e84e92468254700c00a31a7de29fc3f
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Tue Apr 5 15:03:52 2022 -0400
Clean up macro usage in `model::misc` (#1822)
Refactor `impl_from_str!` to cut down on complexity, and move the error
handling logic for `Channel` and `Role` into their respective modules.
Furthermore, remove the unused `misc::UserParseError` enum, as it's long
been replaced by `argument_convert::UserParseError` in use.
commit 8c9670fbedec8d36259ae2260787f7bf346fb409
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Tue Apr 5 15:02:56 2022 -0400
Alter `Guild::member_named`'s implementation to use `utils::parse_user_tag` (#1821)
commit f6c4db0486254c082761711161ff5c95f60b66a9
Author: kangalioo <jannik.a.schaper@web.de>
Date: Tue Apr 5 21:01:02 2022 +0200
Fix parsing interactions with DM channel argument (#1819)
commit cdaa70cb80d272c6af9ba4c9a7e2e1d2563e5475
Author: kangalioo <jannik.a.schaper@web.de>
Date: Tue Apr 5 21:00:16 2022 +0200
Make `ArgumentConvert` compatible without the `cache` feature (#1818)
commit 63a1000fca1a52c4ba0e7432e52d6607582b10ed
Author: kangalioo <jannik.a.schaper@web.de>
Date: Tue Apr 5 20:59:09 2022 +0200
Document that the `MESSAGE_CONTENT` intent is now privileged (#1816)
commit 8bca94a73a8b9386d1ac77befc312e1d3536f537
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Tue Apr 5 20:58:24 2022 +0200
Use `Option` in more places in the `ClientBuilder` (#1815)
In [#1634][1], it was assumed that you cannot use the builder anymore after
`await`ing it, which is why `.unwrap()` was used for `get_cache_settings`.
However this isn't entirely correct because mutable references implement
`Future` too, so this example would compile but panic at runtime:
```rust
let mut builder = Client::builder("a");
let client = (&mut builder).await.unwrap();
let settings = builder.get_cache_settings();
```
Instead of unwrapping, a note was added to the docs to reflect this. While this
change isn't necessary for `http`, it avoids creating a new `Http` instance by
using `std::mem::take()` that's most likely never even accessed anyway.
[1]: https://github.com/serenity-rs/serenity/pull/1634
commit c18e889eca2e481e9168b5450610ad0415e198ae
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Tue Apr 5 19:55:48 2022 +0100
Add `users` argument to `utils::content_safe` (#1814)
This adds a new argument to content_safe to allow filtering mentions out from
users not in cache, for example, from `Message::mentions`. This also reworks
slightly how the user is fetched in `clean_users` to keep it DRY and adds to
`test_content_safe` to make sure it isn't broken in future.
commit d67a21d1d74b80f51e3b4e125dbe7bba0c29f86b
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Apr 5 20:52:20 2022 +0200
Simplify the hidden preparation code in doc examples (#1810)
- Instead of creating the required types, the code is wrapped in a
function with the required types as parameters.
- Remove unused imports, unneeded `fn run()` and `async fn`.
- Use minimal json data to initial `Emoji` structs.
commit 1ed7ac5eab8e2955d9c0f6e913316e55cdff13e5
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat Apr 2 20:30:41 2022 +0200
Remove unused `client::Extras` struct (#1812)
This struct is a leftover from the asynchronous refactoring and was
replaced with the `ClientBuilder` in serenity v0.9.
commit a292c2fcb6826e0305d078b1a08a4535ef2d9c9d
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Sat Apr 2 16:52:57 2022 +0100
Remove kind check for sending webhook components (#1811)
commit b13867a1953fa6240423845824bba0753933a983
Author: Alex M. M <acdenissk69@gmail.com>
Date: Sat Apr 2 16:39:01 2022 +0200
Fix compilation errors
commit 1ce8060b0ae5622d5c698f371988f59c8deb158d
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat Apr 2 15:58:04 2022 +0200
Remove the `unstable_discord_api` feature guard from the application commands (#1785)
commit dc400de52a054cf30ea6aa7cc75d530e2c4d4d37
Author: Gnome! <45660393+GnomedDev@users.noreply.github.com>
Date: Sat Apr 2 00:17:38 2022 +0100
Add attachment support to interaction responses (#1808)
commit 00366204b19d5585cc0ff1a131f36d42f8257d02
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat Apr 2 01:13:43 2022 +0200
Turn the resolved target of the command interaction data into a method (#1802)
This defers the cloning of the resolved data to the calling of the `target`
method instead of cloning it during deserialization. It also removes possible
panics on missing data.
BREAKING CHANGE: The `ApplicationCommandInteractionData::target` field
is replaced with the `target(&self) -> Option<ResolvedTarget>` method.
commit 28e67324f0a8836538b92305298b31ed858d9eea
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Fri Apr 1 19:10:52 2022 -0400
Clean up API around Mention/Mentionable (#1801)
This removes `MentionableImpl` and makes `Mention` an enum directly.
Furthermore, a blanket impl of `Mentionable` for any `Copy` types is introduced
-- this means the various `{Channel,User,Role,Emoji}Id` types. For any
non-`Copy` types, the implementation of `From<&'_ T> for Mention` has been
removed, as users can just call `T::mention()` instead.
commit aada1b95be893b9ef7f1acecf9245d224149878b
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat Apr 2 00:57:59 2022 +0200
Use the new builder method for ephemeral messages in example (#1809)
commit c9e4f27512cc32aa36ea825223bce1349d9bd79a
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Fri Apr 1 18:57:19 2022 -0400
Replace custom trait with `Into<Content>` (#1800)
commit 787e7d93fd09fe995df412474bb57840cc954487
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat Apr 2 00:56:48 2022 +0200
Make the non-cache version of the `shard_id` methods synchronous (#1807)
This was overlooked when the cache was made synchronous.
commit 1976428ff54976784823c805609a259fe2e5174a
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat Apr 2 00:56:25 2022 +0200
Remove sunsetted store channel type (#1806)
commit a9d191900f926bdeea57faa24f745e3c1f8741ab
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed Mar 30 21:00:32 2022 +0200
Fix `unused_imports` warning (#1799)
commit c92acfd89e136b951b61e81b469e76163f286eb2
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed Mar 30 21:00:16 2022 +0200
Remove superfluous error heading (#1798)
commit 985212aff1cc73515261846e4e9eeb3867c5bcd4
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed Mar 30 13:11:49 2022 +0200
Add new audit change variant for `image_hash` key (#1794)
This adds the `Change::ImageHash` variant for changed guild scheduled
event cover images.
commit 1e427c62f2126fa22cc95cbafa2a471e4bc319c6
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed Mar 30 13:11:09 2022 +0200
Remove unused `ApplicationInfo` & `BotApplication` structs (#1796)
commit 3a3e3995abb6cc87681d72c88a033ecd9326e66e
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Mar 29 18:05:43 2022 +0200
Add `.git-blame-ignore-revs` file (#1793)
The file contains commit hashes of noisy commits that can be ignored and
is meant for use with `git blame --ignore-revs-file` or via `git config`.
```
git config blame.ignoreRevsFile .git-blame-ignore-revs
```
commit 283af983e769b2155b440ab4d610e7fe8ed9b36d
Author: Narturio <6959837+pascalharp@users.noreply.github.com>
Date: Tue Mar 29 15:33:48 2022 +0000
Add function to `CreateInteractionResponseData` to set or unset the ephemeral flag (#1788)
commit 56cab22b4524f7a188e08a1ef4b8156ab138a8aa
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Mar 29 17:25:05 2022 +0200
Remove manual deserialization of `ApplicationCommandInteractionDataResolved` (#1791)
The implementation can be replaced with `#[serde(default)]`.
commit 11fff2f730aa7de4c8e96986f8a958e542ec82be
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Mar 29 17:24:44 2022 +0200
Fix typo in environment variable in `Publish docs` build job (#1792)
commit 66f8be788c5a9dc7aed355fb074c7dd746fbb60f
Author: nickelc <constantin.nickel@gmail.com>
Date: Mon Mar 28 00:20:59 2022 +0200
Add method to create `model::Timestamp` from a UNIX timestamp (#1790)
The valid range of UNIX timestamp values depends on the underlying
crate implementation (`chrono` or `time`) and the feature flags enabled
(`time` with `large-dates`).
commit 36eac42126170b41db96479589194f02c7346b88
Author: nickelc <constantin.nickel@gmail.com>
Date: Sat Mar 26 20:42:27 2022 +0100
Pin the Rust version for the build jobs with the nightly toolchain (#1787)
This change makes the build jobs less effected to issues like the current
breakage of `macro_rules!` in the `ring` crate with `nightly-2022-03-23`.
The nightly build job is now defined as a separate build job because the
`env` variable is not supported in expressions that define values in the
build matrix.
commit a75ac697cb20f31f9a046f9c4e04f9c1bda5b76e
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed Mar 23 19:40:53 2022 +0100
Add new message flag `FAILED_TO_MENTION_SOME_ROLES_IN_THREAD` (#1784)
commit 33d402feb0bbc0b47cf28f5bc334a03805a2ffa5
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed Mar 23 19:40:26 2022 +0100
Use `ApplicationFlags` bitflags in the application info structs (#1783)
commit 7a8f2cfb0826ec358594fa680766cacc7eed659b
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed Mar 23 19:39:57 2022 +0100
Unify `std::fmt` imports and `Display` & `Debug` trait implementations (#1782)
This changes all uses of `Debug` and `Display` to be consistent with imports.
What that means is all of the relevant code will look this:
```
use std::fmt;
impl fmt::Display for T {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
// ...
}
}
impl fmt::Debug for T {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
// ...
}
}
```
commit 14fc9c6b5c68a61e37273df6ebb4e82a139efde3
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Wed Mar 23 19:37:55 2022 +0100
Add missing stuff for `GatewayIntents` (#1781)
This:
- brings back `GatewayIntents::GUILD_SCHEDULED_EVENTS` which was added to the `current` branch in pull request #1689, but not to the `next` branch due to the struct being moved.
- adds `MESSAGE_CONTENT` to the privileged intents.
- adds missing methods for `MESSAGE_CONTENT` and `GUILD_SCHEDULED_EVENTS`.
commit 04a57c33c8e785af903860651111624c130a9c63
Author: Konrad Borowski <konrad@borowski.pw>
Date: Tue Mar 22 16:40:21 2022 +0100
Remove `tokio` 0.2 compatibility (#1780)
commit d5b597040cd83c8385de5c4c213c65da8bb46f44
Author: Konrad Borowski <konrad@borowski.pw>
Date: Tue Mar 22 08:09:00 2022 +0100
Update `parking_lot` to 0.12 (#1779)
`parking_lot` is used by dashmap causing duplicate dependencies.
commit 4ff348e3ac90c061c1a08d9e14528cd287fdde9d
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Mar 22 08:04:28 2022 +0100
Update `async-tungstenite` to 0.17 (#1777)
commit 87bb9a8aab5dfe80cb2a65c351ed46c70d07938b
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Mar 22 07:41:33 2022 +0100
Increase MSRV to 1.53 (#1776)
This change is required to bump`async-tungstenite` because the latest `tungstenite` is using
the new `IntoIterator` implementation for arrays.
commit f790f39ac8b418262957b998e9538f5e8198872a
Author: nickelc <constantin.nickel@gmail.com>
Date: Fri Mar 18 02:33:46 2022 +0100
Rename the enum sub types of the audit log actions (#1769)
The enums represent different action types and not different entity types.
BREAKING CHANGE:
The `audit_log::Action*` enum sub types are renamed to `*Action`.
For instance, `ActionChannel` to `ChannelAction`.
commit 28b4d9a8719390dd085df7040be631dffe87d239
Author: nickelc <constantin.nickel@gmail.com>
Date: Fri Mar 18 02:32:28 2022 +0100
Make the `model::guild::audit_log` module public (#1768)
The `audit_log` module contains a lot of types which clutter the
`guild` module but are probably not used by most serenity users.
The types are still re-exported by the `guild` module but hidden from
the documentation.
commit 61ed6b57035d3894bb51eda21c1674a670940a6c
Author: Jan <66554238+vaporox@users.noreply.github.com>
Date: Sat Mar 12 20:49:25 2022 +0100
Make collector builders synchronous (#1765)
This removes the `Future` implementations for
`ComponentInteractionCollectorBuilder`, `EventCollectorBuilder`,
`MessageCollectorBuilder`, `ModalInteractionCollectorBuilder` and
`ReactionCollectorBuilder` and replaces it with a synchronous build method
because there is nothing that requires it to be `async`.
Because the code inside some macros needed to be changed from `impl<'a>
$name<'a>` to `impl $name`, this also changes the `BoxFuture` of related
structs to be static, making them owned types.
commit 70382290a83a007c3cd2aeb6de8b01a4d9f476dc
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Wed Mar 9 13:11:04 2022 -0500
Fix usage of builder pattern across code, docs, and examples (#1764)
commit e0f2a8ccf887c9ed449c86366e851d6ca022007b
Author: Annika <annika0uwu@gmail.com>
Date: Sat Mar 5 15:45:02 2022 -0800
Support more options for querying invites (#1757)
This adds support for new parameters that Discord has added for the Get Invite
endpoint.
BREAKING CHANGE:
The signatures of `Http::get_invite`, `Route::invite_optioned`, and
`Invite::get` have been altered to support the new parameters.
From
`code: &str, stats: bool`
to
`code: &str, member_counts: bool, expiration: bool, event_id: Option<u64>`.
commit e2e61ca55f1e00b391644f4f09c758ec82c01923
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Wed Mar 2 19:52:35 2022 -0500
Clarify documentation for using components with webhooks (#1759)
commit c6d91bf4e224c1609bff38d61570ccf12f9e9ae0
Author: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Date: Wed Mar 2 18:45:20 2022 -0500
Add components support to ExecuteWebhook and EditWebhookMessage (#1758)
This adds `ExecuteWebhook::{components, set_components}`, as well as
`EditWebhookMessage::components`, which all have the same implementation
as `CreateMessage` and others. Note that per the Discord API, these are only
valid to call on an application-owned webhook.
commit 25311cb53b746dd9ddce540524efe4d111636f29
Author: Alex M. M <acdenissk69@gmail.com>
Date: Wed Mar 2 17:23:00 2022 +0100
Remove usage of `#[doc(cfg(...))]`
commit cf1823a7372d2baca9167d12283807dac1bf3d60
Author: nickelc <constantin.nickel@gmail.com>
Date: Wed Mar 2 14:08:36 2022 +0100
Change the data mapping of `AuditLogs` (#1753)
The `entries` are now mapped as `Vec` to keep the order as returned by
the Discord API (newest first). The fields `users` and `webhooks` are
mapped as `HashMap<ID, ENTITY>` to lookup the entities that are
referenced by the audit log entries.
BREAKING CHANGE:
- The field `AuditLogs::entries` is changed to `Vec<AuditLogEntry>`.
- The fields `users` and `webhooks` are changed to `HashMap<ENTITY_ID, ENTITY>`.
commit 0d3d500e7fc12e01fdc6af6c9d20813a4a6c5cf6
Author: nickelc <constantin.nickel@gmail.com>
Date: Tue Mar 1 21:05:07 2022 +0100
Fix the map…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1183