Unwrap .spawn() to support updated tokio task builder API #2349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling serenity with the
tokio_task_builder
feature enabled, the following error occurs:In this commit tokio's
task::Builder::spawn*
methods were changed to return anstd::io::Result<_>
to allowing opt-in to gracefully handling errors when spawning tasks (PR). According to git it has been present since tokio version 1.21.0The PR says the previous behaviour was to simply panic on failure, so a simple fix is to do the same and
.unwrap()
the value returned from spawning