-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement max_concurrency
support when starting shards
#2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max_concurrency
support when starting shards
GnomedDev
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm yet to test this out on my bot, but here's my first pass review.
2546ca2
to
c299ded
Compare
c299ded
to
646db5f
Compare
646db5f
to
74d356e
Compare
Deduplicate the call to `self.checked_start` by pushing all shards to the queue instead of just any that failed to start, and by falling through in case of a timeout.
74d356e
to
5e37544
Compare
arqunis
approved these changes
Jan 16, 2024
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 22, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Feb 9, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Mar 1, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Mar 10, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Mar 11, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Mar 11, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 13, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Mar 13, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 19, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 19, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Mar 21, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Mar 25, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Mar 29, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Mar 31, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 31, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Apr 1, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
May 14, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
May 14, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
May 23, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
May 28, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 9, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Jun 22, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 22, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 29, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 30, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Aug 16, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 7, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 20, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Oct 20, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 11, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
that referenced
this pull request
Nov 13, 2024
When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 15, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Dec 8, 2024
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 16, 2025
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 1, 2025
…#2661) When a session is first kicked off and we need to start many shards, we can use the value of `max_concurrency` to kick off multiple shards in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
The public API is changed, resulting in miscompilations or unexpected new behaviour for users
client
Related to the `client` module.
discord feature
Related to Discord's functionality.
enhancement
An improvement to Serenity.
gateway
Related to the `gateway` module.
model
Related to the `model` module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #2650.
When a session is first kicked off and we need to start many shards, we can use the value of
max_concurrency
to kick off multiple shards in parallel, and do so in batches every 5 seconds. However, the contents of the batches need to be managed so that we don't accidentally get ratelimited.Simply put, shards are ratelimited together if their IDs are equivalent modulo
max_concurrency
. For example, ifmax_concurrency
is 16, then shards 0 and 16 get ratelimited together, and so do 1 and 17, etc. So, we need to make sure that a given batch doesn't include any conflicting shards that might cause the ratelimit to get hit. If we want a batch of maximal size, we need to wait until the queue contains enough shards to create a full batch.However, we don't always want to wait for a batch to fill up if we know it's not possible for that to happen. This happens when we restart a single shard - in order to avoid waiting the 5 second loop timeout, we need to add a
bool
field toShardQueuerMessage::Shard
to signal whether we want to add the shard to the queue or not.