Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some pedantic lints from the whitelist #2728

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Remove some pedantic lints from the whitelist #2728

merged 1 commit into from
Jan 21, 2024

Conversation

mkrasnitski
Copy link
Collaborator

@mkrasnitski mkrasnitski commented Jan 21, 2024 •
edited
Loading

Also, removed the impls of From<{i32,u64}> for Colour, as it only makes sense to convert infallibly from u32.

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. cache Related to the `cache`-feature. utils Related to the `utils` module. gateway Related to the `gateway` module. labels Jan 21, 2024
@arqunis arqunis added the enhancement An improvement to Serenity. label Jan 21, 2024
@arqunis arqunis merged commit 316497c into serenity-rs:next Jan 21, 2024
22 checks passed
@mkrasnitski mkrasnitski deleted the lints branch January 21, 2024 03:43
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 22, 2024
@mkrasnitski @arqunis
Remove some pedantic lints from the whitelist (serenity-rs#2728)
6e0a188 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Feb 9, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
7583e33 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
arqunis pushed a commit that referenced this pull request Mar 1, 2024
@mkrasnitski @arqunis
Remove some pedantic lints from the whitelist (#2728)
f6b2b1b 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Mar 10, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
694bfd1 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Mar 11, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
e6435c1 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Mar 11, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
27a997c 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
8002a5d 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Mar 13, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
0f6b0f7 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
dc0fdb2 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
d0593cf 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Mar 21, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
b264b4d 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Mar 25, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
55dc602 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Mar 29, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
6b75238 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Mar 31, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
86d489f 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
fe7a5f4 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
fb6a8eb 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
8ebef31 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request May 14, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
2bd27ac 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request May 23, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
48375ff 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request May 28, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
ee15a6c 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
48fc5a1 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Jun 22, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
bd17b88 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
ab14b73 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@mkrasnitski
Remove some pedantic lints from the whitelist (serenity-rs#2728)
c6eea9f 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@mkrasnitski
Remove some pedantic lints from the whitelist (serenity-rs#2728)
b6d5737 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Aug 16, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
e0aaf1c 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
2a6a1d9 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
ff0cf0f 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Oct 20, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
43b69a0 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
c11ba39 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit that referenced this pull request Nov 13, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (#2728)
efc8f26 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@mkrasnitski @GnomedDev
Remove some pedantic lints from the whitelist (serenity-rs#2728)
aceaea4 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@mkrasnitski
Remove some pedantic lints from the whitelist (serenity-rs#2728)
888409d 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@mkrasnitski @arqunis
Remove some pedantic lints from the whitelist (serenity-rs#2728)
ca7059d 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@mkrasnitski
Remove some pedantic lints from the whitelist (serenity-rs#2728)
ee88bc1 
This also removes the impls of `From<{i32,u64}> for Colour`, as it only
makes sense to convert infallibly from `u32`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GnomedDev GnomedDev GnomedDev approved these changes

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
builder Related to the `builder` module. cache Related to the `cache`-feature. enhancement An improvement to Serenity. gateway Related to the `gateway` module. model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkrasnitski @arqunis @GnomedDev