Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove impl AsRef #2736

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Remove impl AsRef #2736

merged 5 commits into from
Jan 24, 2024

Conversation

GnomedDev
Copy link
Member

This should improve compile times even more, by compiling a lot more methods in serenity, instead of in the bot/poise code.

@github-actions github-actions bot added framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate model Related to the `model` module. client Related to the `client` module. builder Related to the `builder` module. http Related to the `http` module. utils Related to the `utils` module. gateway Related to the `gateway` module. examples Related to Serenity's examples. labels Jan 24, 2024
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jan 24, 2024
@arqunis arqunis merged commit e9b699c into serenity-rs:next Jan 24, 2024
22 checks passed
@GnomedDev GnomedDev deleted the remove-impl branch January 24, 2024 18:15
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
762b8c7 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Remove various instances of impl AsRef<T> (serenity-rs#2736)
8d432c7 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
8271529 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
2ea64cc 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
173ade3 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
850930f 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
27feda2 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
e84364d 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
59fe682 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
441f322 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
1621eea 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
df4bbba 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
3253ba5 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
c2baebd 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
a1fddeb 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
193eb41 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
2920fed 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
bd6706b 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
5c366b4 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
6b2747d 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
f5e091f 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
36253ef 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
5bda1e1 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Remove various instances of impl AsRef<T> (serenity-rs#2736)
33c14a2 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Remove various instances of impl AsRef<T> (serenity-rs#2736)
c10f93b 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
a87aedc 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
6afb59d 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
81f2573 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
670cdc7 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
40e653b 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (#2736)
cf79074 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Remove various instances of impl AsRef<T> (serenity-rs#2736)
df68dde 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Remove various instances of impl AsRef<T> (serenity-rs#2736)
18bb2b4 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Remove various instances of impl AsRef<T> (serenity-rs#2736)
8baf3a2 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Remove various instances of impl AsRef<T> (serenity-rs#2736)
cc5419b 
This should improve compile times even more, by compiling a lot more
methods in Serenity, instead of the user's code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. client Related to the `client` module. enhancement An improvement to Serenity. examples Related to Serenity's examples. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate gateway Related to the `gateway` module. http Related to the `http` module. model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis