Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix massive code size of client::dispatch #2739

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Fix massive code size of client::dispatch #2739

merged 1 commit into from
Jan 25, 2024

Conversation

GnomedDev
Copy link
Member

@GnomedDev GnomedDev commented Jan 24, 2024 •
edited
Loading

This replaces fancy iter stuff with just writing the code, and therefore reduces the code size significantly and spawns less tasks.

@github-actions github-actions bot added the client Related to the `client` module. label Jan 24, 2024
@GnomedDev GnomedDev marked this pull request as ready for review January 25, 2024 18:40
@GnomedDev
Copy link
Member Author

This is ready as-is.

@arqunis arqunis added the enhancement An improvement to Serenity. label Jan 25, 2024
@arqunis arqunis merged commit 6ba5170 into serenity-rs:next Jan 25, 2024
21 checks passed
@GnomedDev GnomedDev deleted the shrink-client-dispatch branch January 25, 2024 18:59
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
8dc8ca5 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Fix massive code size of client::dispatch (serenity-rs#2739)
b896ff7 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
d4ba70d 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
ba043c6 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
7fad6ae 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
e8215a7 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
c0891e0 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
fe73d8a 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
287f968 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
449a21c 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
f6a7c5b 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
5567568 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
98b97ac 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
e3c0db4 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
dcc059a 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
74e4bd7 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
f7ee648 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
71abb5a 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
675937e 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
da0ce6e 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
90f52b9 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
a4055d2 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
443af77 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Fix massive code size of client::dispatch (serenity-rs#2739)
cfa6234 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Fix massive code size of client::dispatch (serenity-rs#2739)
cb8bf1d 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
d59d5fb 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
94c8e15 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
5502c56 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
cdf37f3 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
567ff69 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Fix massive code size of client::dispatch (#2739)
d822759 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Fix massive code size of client::dispatch (serenity-rs#2739)
eadc5db 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Fix massive code size of client::dispatch (serenity-rs#2739)
e59919d 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Fix massive code size of client::dispatch (serenity-rs#2739)
9c24f8b 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Fix massive code size of client::dispatch (serenity-rs#2739)
7acf9cf 
This replaces fancy iter stuff with just writing the code, and therefore
reduces the code size significantly and spawns less tasks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
client Related to the `client` module. enhancement An improvement to Serenity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis