-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid HashMap in ShardQueue #2750
Conversation
Actually, we could even use a regular |
Sure, good idea. |
Looking at your changes in |
I definitely see that, but I believe that the type inference problems are worth it to make indexing using the length type provided work. |
I don't quite understand the benefit of indexing with the length type. What does it provide? |
If the type for indexing does not match the type returned from |
82d0500
to
f5cb86c
Compare
This avoids hashing costs, is probably more cache efficient, and avoids storing duplicate information (length of buckets and max concurrency are equal).