Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the message cache #2757

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Simplify the message cache #2757

merged 1 commit into from
Feb 9, 2024

Conversation

GnomedDev
Copy link
Member

@GnomedDev GnomedDev commented Feb 8, 2024 •
edited
Loading

This PR:

  • Reduces complexity by only storing messages in one field
  • Allows the user to get a sorted view of the messages
  • Speeds up the MessageCreate path
  • but may slow down the MessageUpdate path, as it has to iterate over the messages in the channel's cache.

@github-actions github-actions bot added client Related to the `client` module. cache Related to the `cache`-feature. labels Feb 8, 2024
@GnomedDev GnomedDev force-pushed the remove-duplicate-message branch from 9570061 to b6a70a6 Compare February 8, 2024 21:29
@github-actions github-actions bot added framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate model Related to the `model` module. builder Related to the `builder` module. http Related to the `http` module. utils Related to the `utils` module. gateway Related to the `gateway` module. command_attr Related to the `command_attr` crate. examples Related to Serenity's examples. ci Related to the continuous integration. labels Feb 8, 2024
@GnomedDev GnomedDev changed the base branch from current to next February 8, 2024 21:29
@github-actions github-actions bot removed framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate model Related to the `model` module. builder Related to the `builder` module. http Related to the `http` module. utils Related to the `utils` module. gateway Related to the `gateway` module. examples Related to Serenity's examples. ci Related to the continuous integration. labels Feb 8, 2024
@GnomedDev GnomedDev force-pushed the remove-duplicate-message branch from 8b9a4d4 to 9970fde Compare February 9, 2024 16:07
@GnomedDev GnomedDev force-pushed the remove-duplicate-message branch from 9970fde to 901f6f7 Compare February 9, 2024 17:02
arqunis
arqunis approved these changes Feb 9, 2024
View reviewed changes
src/cache/event.rs Show resolved Hide resolved
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Feb 9, 2024
@GnomedDev GnomedDev merged commit 1775e6f into serenity-rs:next Feb 9, 2024
21 checks passed
@GnomedDev GnomedDev deleted the remove-duplicate-message branch February 9, 2024 17:50
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Simplify the message cache (#2757)
6791505
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
6ca33d2
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
cc58f19
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Simplify the message cache (#2757)
82f6e10
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Simplify the message cache (#2757)
26278cc
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Simplify the message cache (#2757)
a1ab3c2
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Simplify the message cache (#2757)
173d2b6
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Simplify the message cache (#2757)
62aeda2
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
80acbd2
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
ff76803
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
e4feb11
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Simplify the message cache (#2757)
0540055
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Simplify the message cache (#2757)
18ecf9e
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Simplify the message cache (#2757)
1fc7c17
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
c91cdea
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Simplify the message cache (#2757)
940598e
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
92df04b
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Simplify the message cache (serenity-rs#2757)
ca8c965
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Simplify the message cache (serenity-rs#2757)
e32227d
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Simplify the message cache (#2757)
f1e76d0
@GnomedDev GnomedDev removed the command_attr Related to the `command_attr` crate. label Aug 30, 2024
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
06a0e09
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
d2c8732
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Simplify the message cache (#2757)
1a5608b
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
7ec73af
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Simplify the message cache (#2757)
4b1cbb7
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Simplify the message cache (serenity-rs#2757)
71db8ff
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Simplify the message cache (serenity-rs#2757)
430a68c
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Simplify the message cache (serenity-rs#2757)
3b654c0
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Simplify the message cache (serenity-rs#2757)
955ccf9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users cache Related to the `cache`-feature. client Related to the `client` module. enhancement An improvement to Serenity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis