Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to strum for fullevent and event #2788

Merged
merged 2 commits into from
Mar 10, 2024
Merged

switch to strum for fullevent and event #2788

merged 2 commits into from
Mar 10, 2024

Conversation

cheesycod
Copy link
Contributor

Add Strum for getting variant names and list of all variants for large enums such as FullEvent and Event. Also removes a hack (Event::name) where serde is used to get the variant name

@github-actions github-actions bot added model Related to the `model` module. client Related to the `client` module. labels Mar 10, 2024
GnomedDev
GnomedDev requested changes Mar 10, 2024
View reviewed changes
Copy link
Member

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick

Cargo.toml Outdated Show resolved Hide resolved
@cheesycod
Squashed commit of the following:
b23e410 
commit 1b28505
Author: Sanandan Sashikumar <cheesycod@outlook.com>
Date:   Sun Mar 10 14:14:02 2024 +0000

    formatting

commit 0f46d73
Author: a <a@a.com>
Date:   Sun Mar 10 14:10:33 2024 +0000

    remove strum_macros dependency

commit d37b6ae
Author: a <a@a.com>
Date:   Sun Mar 10 14:02:29 2024 +0000

    oops

commit 06f3cab
Author: a <a@a.com>
Date:   Sun Mar 10 14:00:36 2024 +0000

    use intostaticstr

commit 5e52e02
Author: a <a@a.com>
Date:   Sun Mar 10 13:59:01 2024 +0000

    switch to strum for fullevent and event
@GnomedDev GnomedDev merged commit 91baacb into serenity-rs:next Mar 10, 2024
21 checks passed
GnomedDev pushed a commit that referenced this pull request Mar 10, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
d611827
GnomedDev pushed a commit that referenced this pull request Mar 11, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
8ea5d68
GnomedDev pushed a commit that referenced this pull request Mar 11, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
dadcb29
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
206564c
GnomedDev pushed a commit that referenced this pull request Mar 13, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
e5eae3a
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
fe523b2
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
5db9c80
GnomedDev pushed a commit that referenced this pull request Mar 21, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
669bb15
GnomedDev pushed a commit that referenced this pull request Mar 25, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
0649928
GnomedDev pushed a commit that referenced this pull request Mar 25, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
f00007f
GnomedDev pushed a commit that referenced this pull request Mar 29, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
7692bb2
GnomedDev pushed a commit that referenced this pull request Mar 31, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
a89fe31
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
4fa558f
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
3a347d5
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
a2f22d2
GnomedDev pushed a commit that referenced this pull request May 14, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
c301a03
GnomedDev pushed a commit that referenced this pull request May 23, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
a79e4cf
GnomedDev pushed a commit that referenced this pull request May 28, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
ea93379
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
f002c9c
GnomedDev pushed a commit that referenced this pull request Jun 22, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
ab167f4
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
6d3fc9f
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@cheesycod @mkrasnitski
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
f70fc58
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@cheesycod @mkrasnitski
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
f7acda9
GnomedDev pushed a commit that referenced this pull request Aug 16, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
0535012
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
43492e8
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
e65a416
GnomedDev pushed a commit that referenced this pull request Oct 20, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
d8410a8
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
ad1602b
GnomedDev pushed a commit that referenced this pull request Nov 13, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (#2788)
c387d7a
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@cheesycod @GnomedDev
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
087e08b
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@cheesycod @mkrasnitski
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
1924acd
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@cheesycod @arqunis
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
c6ca561
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@cheesycod @mkrasnitski
Apply Strum derives for FullEvent and Event (serenity-rs#2788)
d0c459b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GnomedDev GnomedDev GnomedDev approved these changes

Assignees
No one assigned
Labels
client Related to the `client` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheesycod @GnomedDev