Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ExtractMap instead of HashMap when possible #2797

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Use ExtractMap instead of HashMap when possible #2797

merged 1 commit into from
Mar 17, 2024

Conversation

GnomedDev
Copy link
Member

@GnomedDev GnomedDev commented Mar 13, 2024 •
edited
Loading

ExtractMap is HashSet with a Map interface to prevent duplicating the key if it needs to be stored in the value. This swaps serenity to using it which improves memory efficiency and maybe runtime performance while deserialising as only the value needs to be deserialised.

@github-actions github-actions bot added model Related to the `model` module. client Related to the `client` module. cache Related to the `cache`-feature. http Related to the `http` module. utils Related to the `utils` module. labels Mar 13, 2024
@GnomedDev GnomedDev force-pushed the extract-ma branch 3 times, most recently from c8928f1 to 48f5786 Compare March 13, 2024 23:57
@GnomedDev GnomedDev marked this pull request as ready for review March 17, 2024 13:27
@GnomedDev
Copy link
Member Author

Just published extract_map and a typesize compatible version, so ready for review.

@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users dependencies Related to Serenity dependencies. labels Mar 17, 2024
@GnomedDev GnomedDev merged commit 50dc4e6 into serenity-rs:next Mar 17, 2024
21 checks passed
@GnomedDev GnomedDev deleted the extract-ma branch March 17, 2024 23:37
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
7b3b87c
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
2cb925d
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
cccd382
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
d35624a
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
e6fa383
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
022986a
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
aa9632e
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
b6b35b5
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
613b4a1
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
efc8ae1
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
d019b41
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
451e543
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
bbd4c4d
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
d4bbc33
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
e0e478d
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
fea571e
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
ed7eb2e
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
aa0f7a8
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
8e600b3
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
806fe23
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
1882699
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
3582be0
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
da9850e
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (#2797)
816c74f
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
e283d66
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
94ed223
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
cd84fb5
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Use ExtractMap instead of HashMap when possible (serenity-rs#2797)
b7e303f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users cache Related to the `cache`-feature. client Related to the `client` module. dependencies Related to Serenity dependencies. enhancement An improvement to Serenity. http Related to the `http` module. model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis