Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct docs for UserId::to_user #2809

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Correct docs for UserId::to_user #2809

merged 1 commit into from
Apr 9, 2024

Conversation

jamesbt365
Copy link
Member

@jamesbt365 jamesbt365 commented Mar 20, 2024 •
edited
Loading

The docs were never updated after #2662 removed the user cache.

I'm yet to decide what to do with Reaction::User and its usage of to_user, the docs are wrong too.

@github-actions github-actions bot added the model Related to the `model` module. label Mar 20, 2024
@GnomedDev GnomedDev force-pushed the next branch 3 times, most recently from aa90cc6 to 276c192 Compare March 25, 2024 22:27
@GnomedDev GnomedDev force-pushed the next branch 2 times, most recently from 146f94a to b613343 Compare March 31, 2024 12:33
@jamesbt365 jamesbt365 mentioned this pull request Apr 9, 2024
Open
@jamesbt365 jamesbt365 marked this pull request as ready for review April 9, 2024 14:51
@arqunis arqunis added docs Related to documentation. fix A solution to an existing bug. labels Apr 9, 2024
@arqunis arqunis merged commit 95479f3 into serenity-rs:next Apr 9, 2024
21 checks passed
@jamesbt365 jamesbt365 deleted the to_user branch April 10, 2024 16:03
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (serenity-rs#2809)
1662f99 
The documentation was never updated after serenity-rs#2662 removed the user cache.
GnomedDev pushed a commit that referenced this pull request May 14, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (#2809)
097b823 
The documentation was never updated after #2662 removed the user cache.
GnomedDev pushed a commit that referenced this pull request May 23, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (#2809)
68e3816 
The documentation was never updated after #2662 removed the user cache.
GnomedDev pushed a commit that referenced this pull request May 28, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (#2809)
a79bb5f 
The documentation was never updated after #2662 removed the user cache.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (serenity-rs#2809)
c3f8ca9 
The documentation was never updated after serenity-rs#2662 removed the user cache.
GnomedDev pushed a commit that referenced this pull request Jun 22, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (#2809)
32f5de1 
The documentation was never updated after #2662 removed the user cache.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (serenity-rs#2809)
cbf605c 
The documentation was never updated after serenity-rs#2662 removed the user cache.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@jamesbt365 @mkrasnitski
Correct documentation for UserId::to_user (serenity-rs#2809)
6828336 
The documentation was never updated after serenity-rs#2662 removed the user cache.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@jamesbt365 @mkrasnitski
Correct documentation for UserId::to_user (serenity-rs#2809)
fd045a0 
The documentation was never updated after serenity-rs#2662 removed the user cache.
GnomedDev pushed a commit that referenced this pull request Aug 16, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (#2809)
edc3707 
The documentation was never updated after #2662 removed the user cache.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (serenity-rs#2809)
cef0302 
The documentation was never updated after serenity-rs#2662 removed the user cache.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (serenity-rs#2809)
87669e2 
The documentation was never updated after serenity-rs#2662 removed the user cache.
GnomedDev pushed a commit that referenced this pull request Oct 20, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (#2809)
69bd078 
The documentation was never updated after #2662 removed the user cache.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (serenity-rs#2809)
4be01f3 
The documentation was never updated after serenity-rs#2662 removed the user cache.
GnomedDev pushed a commit that referenced this pull request Nov 13, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (#2809)
18dd2f3 
The documentation was never updated after #2662 removed the user cache.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@jamesbt365 @GnomedDev
Correct documentation for UserId::to_user (serenity-rs#2809)
1c66822 
The documentation was never updated after serenity-rs#2662 removed the user cache.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@jamesbt365 @mkrasnitski
Correct documentation for UserId::to_user (serenity-rs#2809)
6a9bfec 
The documentation was never updated after serenity-rs#2662 removed the user cache.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@jamesbt365 @arqunis
Correct documentation for UserId::to_user (serenity-rs#2809)
866c6f0 
The documentation was never updated after serenity-rs#2662 removed the user cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
docs Related to documentation. fix A solution to an existing bug. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbt365 @arqunis